Skip to content

[Bugfix] Fix Nemotron Parse loading#37407

Merged
DarkLight1337 merged 10 commits intovllm-project:mainfrom
DarkLight1337:update-tests
Mar 19, 2026
Merged

[Bugfix] Fix Nemotron Parse loading#37407
DarkLight1337 merged 10 commits intovllm-project:mainfrom
DarkLight1337:update-tests

Conversation

@DarkLight1337
Copy link
Copy Markdown
Member

@DarkLight1337 DarkLight1337 commented Mar 18, 2026

Purpose

Test Plan

Test Result


Essential Elements of an Effective PR Description Checklist
  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.
  • (Optional) Release notes update. If your change is user facing, please update the release notes draft in the Google Doc.

Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
@DarkLight1337 DarkLight1337 requested a review from ywang96 as a code owner March 18, 2026 09:50
@DarkLight1337 DarkLight1337 added rocm Related to AMD ROCm ready ONLY add when PR is ready to merge/full CI is needed labels Mar 18, 2026
@github-project-automation github-project-automation bot moved this to Todo in AMD Mar 18, 2026
@mergify mergify bot added the multi-modality Related to multi-modality (#4194) label Mar 18, 2026
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates test markers by removing the core_model tag and unnecessary create_new_process_for_each_test usage, which aligns with the goal of refining the test suite. It also re-enables a previously skipped test. The most significant change is a fix in nemotron_parse.py intended to correct weight loading. However, this fix appears to introduce a new issue by using integer shard IDs for a layer that expects string identifiers, which could cause a crash. I've provided a critical review comment with a suggested correction for this.

Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
@DarkLight1337 DarkLight1337 requested a review from Isotr0py March 18, 2026 10:35
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
@Isotr0py Isotr0py enabled auto-merge (squash) March 18, 2026 11:33
@DarkLight1337 DarkLight1337 disabled auto-merge March 18, 2026 12:00
@DarkLight1337 DarkLight1337 enabled auto-merge (squash) March 18, 2026 12:00
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
@DarkLight1337
Copy link
Copy Markdown
Member Author

Multi-Modal Models (Extended) 2 should be fixed in #37324 so let's merge that one first

Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
@DarkLight1337 DarkLight1337 changed the title [CI/Build] Update test markers [Bugfix] Fix Nemotron Parse loading Mar 18, 2026
@DarkLight1337 DarkLight1337 disabled auto-merge March 18, 2026 18:24
@DarkLight1337 DarkLight1337 enabled auto-merge (squash) March 18, 2026 18:24
@mergify mergify bot added the bug Something isn't working label Mar 18, 2026
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
@mergify
Copy link
Copy Markdown

mergify bot commented Mar 19, 2026

Hi @DarkLight1337, the pre-commit checks have failed. Please run:

uv pip install pre-commit>=4.5.1
pre-commit install
pre-commit run --all-files

Then, commit the changes and push to your branch.

For future commits, pre-commit will run automatically on changed files before each commit.

Tip

Is mypy failing?
mypy is run differently in CI. If the failure is related to this check, please use the following command to run it locally:
# For mypy (substitute "3.10" with the failing version if needed)
pre-commit run --hook-stage manual mypy-3.10

Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
@DarkLight1337 DarkLight1337 merged commit 765e461 into vllm-project:main Mar 19, 2026
57 of 58 checks passed
@DarkLight1337 DarkLight1337 deleted the update-tests branch March 19, 2026 09:55
@github-project-automation github-project-automation bot moved this from Todo to Done in AMD Mar 19, 2026
fxdawnn pushed a commit to fxdawnn/vllm that referenced this pull request Mar 19, 2026
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
chooper26 pushed a commit to intellistream/vllm-hust that referenced this pull request Mar 21, 2026
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
SouthWest7 pushed a commit to SouthWest7/vllm that referenced this pull request Mar 27, 2026
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
khairulkabir1661 pushed a commit to khairulkabir1661/vllm that referenced this pull request Mar 27, 2026
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
Monishver11 pushed a commit to Monishver11/vllm that referenced this pull request Mar 27, 2026
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
Signed-off-by: Monishver Chandrasekaran <monishverchandrasekaran@gmail.com>
JiantaoXu pushed a commit to JiantaoXu/vllm that referenced this pull request Mar 28, 2026
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
vrdn-23 pushed a commit to vrdn-23/vllm that referenced this pull request Mar 30, 2026
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
Signed-off-by: Vinay Damodaran <vrdn@hey.com>
EricccYang pushed a commit to EricccYang/vllm that referenced this pull request Apr 1, 2026
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
Signed-off-by: EricccYang <yangyang4991@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working multi-modality Related to multi-modality (#4194) ready ONLY add when PR is ready to merge/full CI is needed rocm Related to AMD ROCm

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants