[Bugfix] Fix Nemotron Parse loading#37407
Conversation
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
There was a problem hiding this comment.
Code Review
This pull request updates test markers by removing the core_model tag and unnecessary create_new_process_for_each_test usage, which aligns with the goal of refining the test suite. It also re-enables a previously skipped test. The most significant change is a fix in nemotron_parse.py intended to correct weight loading. However, this fix appears to introduce a new issue by using integer shard IDs for a layer that expects string identifiers, which could cause a crash. I've provided a critical review comment with a suggested correction for this.
|
Multi-Modal Models (Extended) 2 should be fixed in #37324 so let's merge that one first |
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
|
Hi @DarkLight1337, the pre-commit checks have failed. Please run: uv pip install pre-commit>=4.5.1
pre-commit install
pre-commit run --all-filesThen, commit the changes and push to your branch. For future commits, Tip Is
|
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk> Signed-off-by: Monishver Chandrasekaran <monishverchandrasekaran@gmail.com>
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk> Signed-off-by: Vinay Damodaran <vrdn@hey.com>
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk> Signed-off-by: EricccYang <yangyang4991@gmail.com>
Purpose
core_modeltag from Keye-VL and Nemotron Parse tests as they are less importantTest Plan
Test Result
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.