[ROCm] Fix KV copy methods and auto-select attention backend for ROCm#36845
Merged
tjtanaa merged 2 commits intovllm-project:mainfrom Mar 16, 2026
Merged
[ROCm] Fix KV copy methods and auto-select attention backend for ROCm#36845tjtanaa merged 2 commits intovllm-project:mainfrom
tjtanaa merged 2 commits intovllm-project:mainfrom
Conversation
Signed-off-by: Andreas Karatzas <akaratza@amd.com>
AndreasKaratzas
requested review from
ApostaC,
orozery and
tjtanaa
as code owners
AndreasKaratzas
added
the
ready
Member
|
cc @tjtanaa |
Lucaskabela
pushed a commit
to Lucaskabela/vllm
that referenced
this pull request
Mar 17, 2026
…vllm-project#36845) Signed-off-by: Andreas Karatzas <akaratza@amd.com>
wendyliu235
pushed a commit
to wendyliu235/vllm-public
that referenced
this pull request
Mar 18, 2026
…vllm-project#36845) Signed-off-by: Andreas Karatzas <akaratza@amd.com>
fxdawnn
pushed a commit
to fxdawnn/vllm
that referenced
this pull request
Mar 19, 2026
…vllm-project#36845) Signed-off-by: Andreas Karatzas <akaratza@amd.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added
insert_blocks_to_deviceandswap_out_blocks_to_hosttoRocmPlatform. These were only defined onCudaPlatform, causing aTypeError: 'NoneType' object is not callablecrash whenNixlConnectortried to copy KV blocks between GPU and CPU buffers during prefill/decode disaggregation on ROCm.Updated
spec_decode_acceptance_test.shto auto-select the attention backend based on the detected GPU platform:TRITON_ATTNon ROCm,FLASH_ATTNon NVIDIA. Previously the script hardcodedFLASH_ATTNregardless of platform. The backend can still be overridden viaATTENTION_BACKEND=<value>.cc @kenroche