[BugFix] Fix cmake based incremental install (wrong vllm install dir)#35773
Merged
vllm-bot merged 2 commits intovllm-project:mainfrom Mar 3, 2026
Merged
[BugFix] Fix cmake based incremental install (wrong vllm install dir)#35773vllm-bot merged 2 commits intovllm-project:mainfrom
vllm-bot merged 2 commits intovllm-project:mainfrom
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request addresses a bug in the CMake-based installation process where installing multiple vllm-flash-attn components at once would lead to an incorrect, doubly-nested installation directory. The original code used a foreach loop that modified the CMAKE_INSTALL_PREFIX for each component, causing the issue. The fix replaces this loop with install(CODE ... ALL_COMPONENTS), which correctly ensures the prefix modification logic runs only once per installation. This change is a clean and effective solution to the problem.
yewentao256
approved these changes
Mar 2, 2026
Member
yewentao256
left a comment
yewentao256
left a comment
There was a problem hiding this comment.
Verified that this one fix the issue
Copilot AI
pushed a commit
to machov/vllm
that referenced
this pull request
Mar 10, 2026
…vllm-project#35773) Signed-off-by: Lucas Wilkinson <lwilkins@redhat.com> Co-authored-by: Wentao Ye <44945378+yewentao256@users.noreply.github.com>
avinashsingh77
pushed a commit
to avinashsingh77/vllm
that referenced
this pull request
Mar 12, 2026
…vllm-project#35773) Signed-off-by: Lucas Wilkinson <lwilkins@redhat.com> Co-authored-by: Wentao Ye <44945378+yewentao256@users.noreply.github.com>
wendyliu235
pushed a commit
to wendyliu235/vllm-public
that referenced
this pull request
Mar 18, 2026
…vllm-project#35773) Signed-off-by: Lucas Wilkinson <lwilkins@redhat.com> Co-authored-by: Wentao Ye <44945378+yewentao256@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
alternative #35768, (broke by: 8b5014d) when using
all components are installed at once, unlike setup.py based methods like
python setup.py build_ext --inplaceoruv pip install -e .that install components one-by-one. This led to double appending ofvllmto the path