Closed
Conversation
Signed-off-by: yewentao256 <zhyanwentao@126.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request addresses a bug in the installation directory for FlashAttention (FA) components within the CMake build process. The changes remove lines that were modifying the CMAKE_INSTALL_PREFIX, which caused FA to be installed into a nested subdirectory (vllm/vllm/vllm-flash-attn...). By removing this prefix manipulation, the installation path is corrected to the intended vllm/vllm-flash-attn. The fix is direct and appears to resolve the described issue.
LucasWilkinson
requested changes
Mar 2, 2026
Collaborator
LucasWilkinson
left a comment
LucasWilkinson
left a comment
There was a problem hiding this comment.
Can you please elaborate on the specific issue you are seeing?
Member
Author
|
Closing in favor of #35773 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Currently FA will be installed to
vllm/vllm/vllm-flash-attn...which should be corrected tovllm/vllm-flash-attnThis PR solves the issue