[Bugfix] Replace c10::optional with std::optional in topk kernel#34467
[Bugfix] Replace c10::optional with std::optional in topk kernel#34467vllm-bot merged 1 commit intovllm-project:mainfrom
Conversation
|
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run You ask your reviewers to trigger select CI tests on top of Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add If you have any questions, please reach out to us on Slack at https://slack.vllm.ai. 🚀 |
yeqcharlotte
left a comment
There was a problem hiding this comment.
could you fix DCO?
There was a problem hiding this comment.
Code Review
This pull request replaces the deprecated c10::optional with std::optional in the large_context_topk kernel function. The change is correct and aligns with the ongoing effort to migrate away from deprecated c10 utilities. The updated function signature is consistent with its usage and the function it calls (get_params), which already uses std::optional. This is a good code health improvement.
Signed-off-by: Pushpinder Singh <pushpindersingh135@gmail.com>
Head branch was pushed to by a user without write access
…m-project#34467) Signed-off-by: Pushpinder Singh <pushpindersingh135@gmail.com> Signed-off-by: Athrael Soju <athrael.soju@gmail.com>
…m-project#34467) Signed-off-by: Pushpinder Singh <pushpindersingh135@gmail.com> Signed-off-by: wzhao18 <wzhao18.sz@gmail.com>
…m-project#34467) Signed-off-by: Pushpinder Singh <pushpindersingh135@gmail.com> Signed-off-by: Eldar Kurtic <research@neuralmagic.com>
…m-project#34467) Signed-off-by: Pushpinder Singh <pushpindersingh135@gmail.com> Signed-off-by: zjy0516 <riverclouds.zhu@qq.com>
…m-project#34467) Signed-off-by: Pushpinder Singh <pushpindersingh135@gmail.com>
…m-project#34467) Signed-off-by: Pushpinder Singh <pushpindersingh135@gmail.com>
Purpose
Replaced the usage of c10::optional with std::optional as c10::optional is deprecated.
The project has migrated away from it in prior PRs (#11730, #17819, #25602) and header for this function is already using std::optional.
Test Plan
CI
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.