[MISC] replace c10::optional with std::optional#25602
Merged
vllm-bot merged 2 commits intovllm-project:mainfrom Sep 24, 2025
Merged
[MISC] replace c10::optional with std::optional#25602vllm-bot merged 2 commits intovllm-project:mainfrom
vllm-bot merged 2 commits intovllm-project:mainfrom
Conversation
Signed-off-by: Shiyan Deng <dsy842974287@meta.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request correctly replaces the deprecated c10::optional with std::optional in ROCm-specific C++ files, which is a good modernization step. The changes in csrc/rocm/ops.h and csrc/rocm/skinny_gemms.cu are straightforward and correctly implemented. The other changes in the pull request are minor stylistic adjustments to comment indentation. Overall, this is a clean and beneficial refactoring.
houseroad
approved these changes
Sep 24, 2025
Collaborator
houseroad
left a comment
houseroad
left a comment
There was a problem hiding this comment.
Thanks for the fix. Please lint the code.
Signed-off-by: Shiyan Deng <dsy842974287@meta.com>
yewentao256
pushed a commit
that referenced
this pull request
Oct 3, 2025
Signed-off-by: Shiyan Deng <dsy842974287@meta.com> Signed-off-by: yewentao256 <zhyanwentao@126.com>
choprahetarth
pushed a commit
to Tandemn-Labs/vllm
that referenced
this pull request
Oct 11, 2025
Signed-off-by: Shiyan Deng <dsy842974287@meta.com>
lywa1998
pushed a commit
to lywa1998/vllm
that referenced
this pull request
Oct 20, 2025
Signed-off-by: Shiyan Deng <dsy842974287@meta.com>
rtourgeman
pushed a commit
to rtourgeman/vllm
that referenced
this pull request
Nov 10, 2025
Signed-off-by: Shiyan Deng <dsy842974287@meta.com>
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Replace the usage of c10::optional with std::optional as c10::optional is being deprecated.
Test Plan
CI
Test Result
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.