[Bugfix] fix default is_neox_style to be True for deepseekv3.2#34353
Merged
jeejeelee merged 1 commit intovllm-project:mainfrom Feb 11, 2026
Merged
[Bugfix] fix default is_neox_style to be True for deepseekv3.2#34353jeejeelee merged 1 commit intovllm-project:mainfrom
jeejeelee merged 1 commit intovllm-project:mainfrom
Conversation
Signed-off-by: dongxinyu03 <dongxinyu03@baidu.com>
mergify
bot
added
deepseek
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request addresses a bug in the DeepseekV2MLAAttention layer where the default value for is_neox_style for the indexer's rotary embedding was incorrect. The change modifies the default value for the indexer_rope_interleave attribute lookup from True to False. This ensures that if indexer_rope_interleave is not present in the model configuration, is_neox_style correctly defaults to True, which is the expected behavior for DeepSeek models. The fix is straightforward and correct.
jeejeelee
approved these changes
Feb 11, 2026
mgoin
changed the title
khluu
pushed a commit
that referenced
this pull request
Feb 12, 2026
Signed-off-by: dongxinyu03 <dongxinyu03@baidu.com> (cherry picked from commit be7f3d5)
eldarkurtic
pushed a commit
to eldarkurtic/vllm
that referenced
this pull request
Feb 19, 2026
…#34353) Signed-off-by: dongxinyu03 <dongxinyu03@baidu.com> Signed-off-by: Eldar Kurtic <research@neuralmagic.com>
llsj14
pushed a commit
to llsj14/vllm
that referenced
this pull request
Mar 1, 2026
…#34353) Signed-off-by: dongxinyu03 <dongxinyu03@baidu.com>
tunglinwood
pushed a commit
to tunglinwood/vllm
that referenced
this pull request
Mar 4, 2026
…#34353) Signed-off-by: dongxinyu03 <dongxinyu03@baidu.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
To resolve the default style issue with index rope, neox should be True when it's not present in config.
Test Plan
Test Result
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.