Merged
Conversation
jeejeelee
requested review from
DarkLight1337,
ProExpertProg,
WoosukKwon,
hmellor,
houseroad,
mgoin,
robertgshaw2-redhat,
tlrmchlsmth,
yewentao256,
youkaichao and
ywang96
as code owners
mergify
bot
added
deepseek
Isotr0py
approved these changes
Feb 9, 2026
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces support for the GlmMoeDsaForCausalLM model. The changes involve updating various configuration lists and conditional checks across the codebase to recognize and properly handle the new model architecture. A minor adjustment was also made in DeepseekV2Attention to dynamically determine the is_neox_style parameter based on the indexer_rope_interleave configuration. Overall, the changes are well-aligned with the goal of adding new model support and appear to be correctly implemented.
|
is glm 5 based on deepseek 3.2 architecture? |
5 tasks
khluu
pushed a commit
that referenced
this pull request
Feb 12, 2026
(cherry picked from commit 978a37c)
ItzDEXX
pushed a commit
to ItzDEXX/vllm
that referenced
this pull request
Feb 19, 2026
llsj14
pushed a commit
to llsj14/vllm
that referenced
this pull request
Mar 1, 2026
tunglinwood
pushed a commit
to tunglinwood/vllm
that referenced
this pull request
Mar 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Test Plan
Test Result
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.