Skip to content

[Bugfix] Fix DSV3.2 NVFP4 #33932

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
robertgshaw2-redhat merged 2 commits into from
Feb 5, 2026
+4 −2
Merged

[Bugfix] Fix DSV3.2 NVFP4 #33932

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bd7d7e6
Fix
MatthewBonanni Feb 5, 2026
90a4650
Merge branch 'main' into fix_ds32_nvfp4
MatthewBonanni Feb 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions vllm/model_executor/layers/attention/mla_attention.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -530,7 +530,7 @@ def forward_impl(
scale=self._k_scale,
)

if fp8_attention:
if fp8_attention and self.kv_cache_dtype != "fp8_ds_mla":
kv_cache = kv_cache.view(current_platform.fp8_dtype())

# Sparse MLA impls only support forward_mqa (decode-style attention)
Expand Down Expand Up @@ -614,7 +614,7 @@ def forward_impl(
# Convert from (N, B, L) to (B, N, L)
mqa_ql_nope = mqa_ql_nope.transpose(0, 1)

if fp8_attention:
if fp8_attention and self.impl.supports_quant_query_input:
assert mqa_ql_nope.shape[0] == mqa_q_pe.shape[0]
assert mqa_ql_nope.shape[1] == mqa_q_pe.shape[1]
mqa_q = self._decode_concat_quant_fp8_op(
Expand Down Expand Up @@ -1885,6 +1885,8 @@ def __init__(
self.indexer = indexer
self.q_pad_num_heads = q_pad_num_heads

self.supports_quant_query_input = True

# Use flashinfer's optimized concat_mla_k kernel when available.
# The kernel is optimized for DeepSeek V3 dimensions:
# num_heads=128, nope_dim=128, rope_dim=64
Expand Down