[Bugfix] Fix DSV3.2 NVFP4#33932
Merged
robertgshaw2-redhat merged 2 commits intovllm-project:mainfrom Feb 5, 2026
Merged
Conversation
5 tasks
|
This pull request has merge conflicts that must be resolved before it can be |
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a bugfix for Multi-Head Latent Attention (MLA), likely related to DeepSeek V3.2 models using specific quantization formats. The changes prevent an unnecessary and potentially incorrect view casting of the KV cache when the kv_cache_dtype is fp8_ds_mla. Additionally, a safeguard is added to ensure that FP8 query quantization is only performed if the attention implementation supports it, and this support is explicitly enabled for MLACommonImpl. These changes are correct, well-targeted, and improve the robustness of the code. The fix appears solid.
Signed-off-by: Matthew Bonanni <mbonanni@redhat.com>
robertgshaw2-redhat
approved these changes
Feb 5, 2026
ItzDEXX
pushed a commit
to ItzDEXX/vllm
that referenced
this pull request
Feb 19, 2026
Signed-off-by: Matthew Bonanni <mbonanni@redhat.com>
tunglinwood
pushed a commit
to tunglinwood/vllm
that referenced
this pull request
Mar 4, 2026
Signed-off-by: Matthew Bonanni <mbonanni@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Fix #33859
Test Plan
Test Result
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.