Skip to content

Fix tokenizer test for renamed attr on Transformers v5 #33902

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DarkLight1337 merged 2 commits into from
Feb 5, 2026
Merged

Fix tokenizer test for renamed attr on Transformers v5 #33902

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2167639
Fix tokenizer test for renamed attr on Transformers v5
hmellor Feb 2, 2026
c175635
Merge branch 'main' into fix-tokenizer-test-v5
hmellor Feb 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion tests/entrypoints/openai/test_serving_tokens.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
from transformers import AutoTokenizer

from vllm.config import ModelConfig
from vllm.config.utils import getattr_iter
from vllm.v1.engine.detokenizer import check_stop_strings

from ...utils import RemoteOpenAIServer
Expand Down Expand Up @@ -131,7 +132,14 @@ async def test_same_response_as_chat_completions(client, tokenizer, messages):
# Post-EOS generation is undefined and may differ
eos_tokens = {
tokenizer.eos_token_id,
*tokenizer.additional_special_tokens_ids,
*getattr_iter(
tokenizer,
[
"extra_special_tokens_ids", # Transformers v5
"additional_special_tokens_ids", # Transformers v4
],
[],
),
}
# Find first EOS in generated tokens
eos_pos = None
Expand Down