Fix tokenizer test for renamed attr on Transformers v5#33902
Merged
DarkLight1337 merged 2 commits intovllm-project:mainfrom Feb 5, 2026
Merged
Fix tokenizer test for renamed attr on Transformers v5#33902DarkLight1337 merged 2 commits intovllm-project:mainfrom
DarkLight1337 merged 2 commits intovllm-project:mainfrom
Conversation
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
hmellor
requested review from
DarkLight1337,
NickLucche,
aarnphm and
robertgshaw2-redhat
as code owners
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates a tokenizer test to be compatible with both Transformers v4 and v5. The attribute additional_special_tokens_ids was renamed to extra_special_tokens_ids in v5. The change correctly uses the getattr_iter utility to check for both attribute names, ensuring the test runs correctly with either version of the library. The implementation is clean and effectively addresses the compatibility issue. I have no further comments.
DarkLight1337
approved these changes
Feb 5, 2026
github-actions
bot
added
the
ready
ItzDEXX
pushed a commit
to ItzDEXX/vllm
that referenced
this pull request
Feb 19, 2026
…33902) Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
tunglinwood
pushed a commit
to tunglinwood/vllm
that referenced
this pull request
Mar 4, 2026
…33902) Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This attr has been renamed in Transformers v5. This PR updates the test to check both locations.