[Bugfix] (grpc): improve GetServerInfo response consistency and accuracy#33070
Open
pacoxu wants to merge 3 commits intovllm-project:mainfrom
Open
[Bugfix] (grpc): improve GetServerInfo response consistency and accuracy#33070pacoxu wants to merge 3 commits intovllm-project:mainfrom
pacoxu wants to merge 3 commits intovllm-project:mainfrom
Conversation
- Use single time.time() for last_receive_timestamp and uptime_seconds to avoid drift between the two values - Report actual pause state via self.async_llm.is_paused instead of hardcoded False Signed-off-by: Paco Xu <paco.xu@daocloud.io>
74b70e6 to
e5a874e
Compare
Contributor
There was a problem hiding this comment.
Code Review
The pull request effectively addresses two outstanding TODOs in the GetServerInfo gRPC endpoint. It significantly improves the consistency and accuracy of the server's reported state by ensuring that last_receive_timestamp and uptime_seconds are derived from a single timestamp capture, thereby preventing potential time drift. Additionally, the server's pause state is now correctly reported using the actual self.async_llm.is_paused status, rather than a hardcoded False value.
Contributor
|
LGTM |
…time last_receive_timestamp is meant to be the time of the last received request, not the current time; leave a TODO to track it when requests are received. Signed-off-by: Paco Xu <paco.xu@daocloud.io>
Contributor
Author
Added a comment. Thanks for reviewing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Try to fix 2 TODOs.
Test Plan
grpc server endpoint support was added in #30190.
cc @CatherineSue @njhill
Test Result
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.