[CI] fix version comparsion and exclusion patterns in upload-release-wheels.sh#32971
[CI] fix version comparsion and exclusion patterns in upload-release-wheels.sh#32971khluu merged 2 commits intovllm-project:mainfrom
Conversation
…heels.sh Signed-off-by: Shengqi Chen <harry-chen@outlook.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request fixes version comparison logic and exclusion patterns in the release wheel upload script. The version comparison now correctly handles version strings with a 'v' prefix, and a new variable PURE_VERSION is introduced for version strings without the prefix, which is a good improvement. The exclusion pattern for aws s3 cp has been updated to prevent incorrect exclusion of aarch64 wheels. My review includes a suggestion to improve the new exclusion pattern for better clarity and robustness.
khluu
left a comment
khluu
left a comment
There was a problem hiding this comment.
LOL I just opened a PR 2 minutes before you. Let's use yours
Signed-off-by: Shengqi Chen <harry-chen@outlook.com>
There was a problem hiding this comment.
Pull request overview
This PR fixes version comparison and exclusion pattern issues in the release wheel upload script that were identified by @khluu.
Changes:
- Fixed version comparison to correctly compare RELEASE_VERSION with GIT_VERSION (both include 'v' prefix)
- Added PURE_VERSION variable extraction to get version string without 'v' prefix for use in filenames
- Updated AWS S3 copy command to use PURE_VERSION and fixed exclusion pattern to exclude release candidates while preserving aarch64 wheels
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…wheels.sh (vllm-project#32971) Signed-off-by: Shengqi Chen <harry-chen@outlook.com> Signed-off-by: 陈建华 <1647430658@qq.com>
…wheels.sh (vllm-project#32971) Signed-off-by: Shengqi Chen <harry-chen@outlook.com>
…wheels.sh (vllm-project#32971) Signed-off-by: Shengqi Chen <harry-chen@outlook.com>
- [build] fix cu130 related release pipeline steps and publish as nightly image (vllm-project#32522) - [Misc] Replace urllib's `urlparse` with urllib3's `parse_url` (vllm-project#32746) - [Misc] Bump opencv-python dependency version to 4.13 (vllm-project#32668) - [Bugfix] Fix Whisper/encoder-decoder GPU memory leak (vllm-project#32789) - [CI] fix version comparsion and exclusion patterns in upload-release-wheels.sh (vllm-project#32971) - tokenizers: mistral: fix merge conflict - `Dockerfile.tpu.ubi`: add `git` to allow `pip install git+https`
Purpose
@khluu found some issues when trying this script. This PR fixes them.
Test Plan
Normal CI will not trigger this step. Needs to be tested on the next release.
Test Result
N/A
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.