[Misc] Replace urllib's urlparse with urllib3's parse_url

[Isotr0py]

Purpose

• Replace urllib's urlparse with urllib3's parse_url for safer and more standard url parsing.

Test Plan

Test Result

---

Essential Elements of an Effective PR Description Checklist

• The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
• The test plan, such as providing test command.
• The test results, such as pasting the results comparison before and after, or e2e results
• (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.
• (Optional) Release notes update. If your change is user facing, please update the release notes draft in the Google Doc.

[gemini-code-assist]

Code Review

This pull request correctly replaces urllib.parse.urlparse with urllib3.util.parse_url across the codebase. The changes account for the differences in the return values, particularly how None is handled by urllib3. My review includes one suggestion to improve error handling for malformed data URLs to provide clearer error messages.

[gemini-code-assist]

While adding or "" correctly prevents an AttributeError when url_spec.path is None, it can lead to a generic and less informative ValueError if an invalid data URL is provided (e.g., one missing the data part after the comma). It would be more robust to explicitly check for a valid data URL path and raise an error with a more specific message, including the problematic URL.

Suggested change

	url_spec_path = url_spec.path or ""
	data_spec, data = url_spec_path.split(",", 1)
	if not url_spec.path or "," not in url_spec.path:
	raise ValueError(f"Invalid data URL, cannot find data part: {url_spec.unparse()}")
	data_spec, data = url_spec.path.split(",", 1)

[cursor]

Cursor Bugbot has reviewed your changes and found 2 potential issues.

^{Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.}

Comment @cursor review or bugbot run to trigger another review on this PR

[cursor]

Data URLs fail due to urllib3 parse_url scheme detection

High Severity

The switch from urllib.parse.urlparse to urllib3.util.parse_url breaks data URL handling. Data URLs use the data:content format without ://, but parse_url is designed for HTTP URLs and expects scheme://authority/path format. For a data URL like data:image/png;base64,abc, parse_url returns None for the scheme, causing the check if url_spec.scheme == "data" to fail. This results in valid data URLs being rejected with "The URL must be either a HTTP, data or file URL" error, breaking multimodal image/audio/video inputs that use base64 data URLs.

Additional Locations (1)

• vllm/multimodal/utils.py#L190-L217

 

[cursor]

Missing exception handling for LocationParseError in port validation

Medium Severity

The get_vllm_port function catches ValueError from int(port) and then calls parse_url(port) to detect URI-like values and provide helpful error messages. However, urllib3.util.parse_url can raise LocationParseError for certain malformed inputs (e.g., invalid IPv6 addresses, overly long labels), while the original urlparse never raised exceptions. This uncaught exception would bypass the helpful error messages and cause an unexpected crash during application startup when VLLM_PORT is misconfigured with certain malformed values.

 

[DarkLight1337]

I think the failing test is related