[Frontend][3/n] Make pooling entrypoints request schema consensus | EmbedRequest & ClassifyRequest#32905
Merged
noooop merged 20 commits intovllm-project:mainfrom Jan 23, 2026
Merged
Conversation
|
Documentation preview: https://vllm--32905.org.readthedocs.build/en/32905/ |
mergify
bot
added
documentation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request effectively refactors the pooling entrypoint request schemas by introducing EncodingRequestMixin, EmbedRequestMixin, and ClassifyRequestMixin. This change centralizes common parameters, reduces code duplication, and improves maintainability across EmbeddingRequest, ClassificationRequest, and PoolingRequest protocols. The refactoring is well-executed and consistently applied. My review includes a couple of minor fixes for documentation snippet tags to ensure the documentation builds correctly.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Signed-off-by: wang.yuqi <noooop@126.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Signed-off-by: wang.yuqi <noooop@126.com>
noooop
requested review from
DarkLight1337,
NickLucche,
aarnphm,
chaunceyjiang and
robertgshaw2-redhat
as code owners
Collaborator
Author
|
Ready for review |
github-actions
bot
added
the
ready
github-actions
bot
added
the
ready
noooop
commented
Jan 23, 2026
Comment on lines
199
to
201
| ```python | ||
| --8<-- "vllm/entrypoints/openai/protocol.py:completion-sampling-params" | ||
| --8<-- "vllm/entrypoints/openai/completion/protocol.py:completion-sampling-params" | ||
| ``` |
Collaborator
Author
There was a problem hiding this comment.
Fixed some API documentation; there might still be some that need to be fixed.
cwazai
pushed a commit
to cwazai/vllm
that referenced
this pull request
Jan 25, 2026
…mbedRequest & ClassifyRequest (vllm-project#32905) Signed-off-by: wang.yuqi <yuqi.wang@daocloud.io> Signed-off-by: wang.yuqi <noooop@126.com> Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Signed-off-by: 陈建华 <1647430658@qq.com>
lapy
pushed a commit
to lapy/vllm
that referenced
this pull request
Jan 27, 2026
…mbedRequest & ClassifyRequest (vllm-project#32905) Signed-off-by: wang.yuqi <yuqi.wang@daocloud.io> Signed-off-by: wang.yuqi <noooop@126.com> Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
ItzDEXX
pushed a commit
to ItzDEXX/vllm
that referenced
this pull request
Feb 19, 2026
…mbedRequest & ClassifyRequest (vllm-project#32905) Signed-off-by: wang.yuqi <yuqi.wang@daocloud.io> Signed-off-by: wang.yuqi <noooop@126.com> Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Split out the following RequestMixin
address #31784 (comment)
Test Plan
tests/entrypoints/pooling/
Test Result
pass
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.