[Model] rename use_pad_token to use_sep_token#31784
Merged
DarkLight1337 merged 6 commits intovllm-project:mainfrom Jan 6, 2026
Merged
[Model] rename use_pad_token to use_sep_token#31784DarkLight1337 merged 6 commits intovllm-project:mainfrom
DarkLight1337 merged 6 commits intovllm-project:mainfrom
Conversation
Signed-off-by: wang.yuqi <yuqi.wang@daocloud.io>
noooop
requested review from
ProExpertProg,
WoosukKwon,
aarnphm,
chaunceyjiang,
hmellor,
houseroad,
mgoin,
robertgshaw2-redhat,
tlrmchlsmth,
yewentao256 and
youkaichao
as code owners
|
Documentation preview: https://vllm--31784.org.readthedocs.build/en/31784/ |
mergify
bot
added
documentation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request primarily refactors use_pad_token to the more semantically correct use_sep_token across the codebase, which improves clarity. The change includes backward compatibility to avoid breaking existing configurations. Additionally, the MTEB embedding tolerance is increased to address test flakiness. The changes are logical and well-implemented, but I found one critical issue in an example script that needs to be addressed.
DarkLight1337
approved these changes
Jan 6, 2026
Anexdeus
pushed a commit
to Anexdeus/vllm
that referenced
this pull request
Jan 6, 2026
Signed-off-by: wang.yuqi <yuqi.wang@daocloud.io> Signed-off-by: Anexdeus <5142168@mail.ru>
LucasWilkinson
pushed a commit
to neuralmagic/vllm
that referenced
this pull request
Jan 6, 2026
Signed-off-by: wang.yuqi <yuqi.wang@daocloud.io>
yugong333
pushed a commit
to yugong333/vllm
that referenced
this pull request
Jan 9, 2026
Signed-off-by: wang.yuqi <yuqi.wang@daocloud.io>
akh64bit
pushed a commit
to akh64bit/vllm
that referenced
this pull request
Jan 16, 2026
Signed-off-by: wang.yuqi <yuqi.wang@daocloud.io>
dsuhinin
pushed a commit
to dsuhinin/vllm
that referenced
this pull request
Jan 21, 2026
Signed-off-by: wang.yuqi <yuqi.wang@daocloud.io> Signed-off-by: dsuhinin <suhinin.dmitriy@gmail.com>
lzl-mt
reviewed
Jan 22, 2026
| classifier_from_tokens=json.loads(args.classifier_from_tokens), | ||
| method=args.method, | ||
| use_pad_token=args.use_pad_token, | ||
| use_sep_token=args.use_sep_token, |
There was a problem hiding this comment.
the name in add_argument is still use-pad-token
5 tasks
ItzDEXX
pushed a commit
to ItzDEXX/vllm
that referenced
this pull request
Feb 19, 2026
Signed-off-by: wang.yuqi <yuqi.wang@daocloud.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
use_pad_token is for internal use only; modifying it will have minimal impact on users.
Test Plan
models/language/pooling/
models/language/pooling_mteb_test/
Test Result
pass
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.