Skip to content

[PluggableLayer][1/N] Define PluggableLayer (Fix ci)#32744

Merged
ProExpertProg merged 8 commits intovllm-project:mainfrom
whx-sjtu:pluggable_layer
Jan 21, 2026
Merged

[PluggableLayer][1/N] Define PluggableLayer (Fix ci)#32744
ProExpertProg merged 8 commits intovllm-project:mainfrom
whx-sjtu:pluggable_layer

Conversation

@whx-sjtu
Copy link
Contributor

@whx-sjtu whx-sjtu commented Jan 21, 2026

Reapplies #32331 that was reverted in #32725.

Purpose

First implementation of RFC #23786: Define PluggableLayer and apply to MLA as an example.

Test Plan

All ci should pass.

Test Result

All ci should pass.

Essential Elements of an Effective PR Description Checklist
  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.
  • (Optional) Release notes update. If your change is user facing, please update the release notes draft in the Google Doc.

@whx-sjtu whx-sjtu marked this pull request as ready for review January 21, 2026 01:28
@mergify
Copy link

mergify bot commented Jan 21, 2026

Documentation preview: https://vllm--32744.org.readthedocs.build/en/32744/

@mergify mergify bot added the documentation Improvements or additions to documentation label Jan 21, 2026
@whx-sjtu
Copy link
Contributor Author

@ProExpertProg @robertgshaw2-redhat Can you open full ci test for me to find errors please?

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces the PluggableLayer abstraction, a significant refactoring aimed at improving modularity for out-of-tree (OOT) layers. The changes are well-structured, moving op_registry to a global scope and applying PluggableLayer to MultiHeadLatentAttentionWrapper as a practical example. My review focuses on improving the robustness and clarity of the new PluggableLayer and refactored CustomOp APIs. I've identified several areas where the implementation could be made less error-prone and more intuitive for developers, particularly around class instantiation and OOT registration. The docstring for the example usage in mla.py could also be clearer to guide users correctly.

Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.

Comment @cursor review or bugbot run to trigger another review on this PR

@ProExpertProg ProExpertProg added ready ONLY add when PR is ready to merge/full CI is needed ready-run-all-tests Trigger CI with all tests for wide-ranging PRs labels Jan 21, 2026
@ProExpertProg
Copy link
Collaborator

CI running

Signed-off-by: whx-sjtu <2952154980@qq.com>
Signed-off-by: whx-sjtu <2952154980@qq.com>
Signed-off-by: whx-sjtu <2952154980@qq.com>
Signed-off-by: whx-sjtu <2952154980@qq.com>
Signed-off-by: whx-sjtu <2952154980@qq.com>
Signed-off-by: whx-sjtu <2952154980@qq.com>
Signed-off-by: whx-sjtu <2952154980@qq.com>
@wangxiyuan
Copy link
Contributor

@whx-sjtu CI failure looks easy to fix. Just need to address the CustomOp changes in test code.

Signed-off-by: whx-sjtu <2952154980@qq.com>
@whx-sjtu
Copy link
Contributor Author

@whx-sjtu CI failure looks easy to fix. Just need to address the CustomOp changes in test code.

Yes. Working on it now.

@ProExpertProg ProExpertProg merged commit 1861ae8 into vllm-project:main Jan 21, 2026
146 checks passed
monajafi-amd pushed a commit to monajafi-amd/vllm that referenced this pull request Jan 23, 2026
)

Signed-off-by: whx-sjtu <2952154980@qq.com>
Signed-off-by: mohammad najafi <mohammad.najafi@amd.com>
cwazai pushed a commit to cwazai/vllm that referenced this pull request Jan 25, 2026
)

Signed-off-by: whx-sjtu <2952154980@qq.com>
Signed-off-by: 陈建华 <1647430658@qq.com>
lapy pushed a commit to lapy/vllm that referenced this pull request Jan 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation performance Performance-related issues ready ONLY add when PR is ready to merge/full CI is needed ready-run-all-tests Trigger CI with all tests for wide-ranging PRs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants