[PluggableLayer][1/N] Define PluggableLayer (Fix ci)#32744
[PluggableLayer][1/N] Define PluggableLayer (Fix ci)#32744ProExpertProg merged 8 commits intovllm-project:mainfrom
Conversation
|
Documentation preview: https://vllm--32744.org.readthedocs.build/en/32744/ |
|
@ProExpertProg @robertgshaw2-redhat Can you open full ci test for me to find errors please? |
There was a problem hiding this comment.
Code Review
This pull request introduces the PluggableLayer abstraction, a significant refactoring aimed at improving modularity for out-of-tree (OOT) layers. The changes are well-structured, moving op_registry to a global scope and applying PluggableLayer to MultiHeadLatentAttentionWrapper as a practical example. My review focuses on improving the robustness and clarity of the new PluggableLayer and refactored CustomOp APIs. I've identified several areas where the implementation could be made less error-prone and more intuitive for developers, particularly around class instantiation and OOT registration. The docstring for the example usage in mla.py could also be clearer to guide users correctly.
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
Comment @cursor review or bugbot run to trigger another review on this PR
|
CI running |
Signed-off-by: whx-sjtu <2952154980@qq.com>
Signed-off-by: whx-sjtu <2952154980@qq.com>
Signed-off-by: whx-sjtu <2952154980@qq.com>
Signed-off-by: whx-sjtu <2952154980@qq.com>
Signed-off-by: whx-sjtu <2952154980@qq.com>
cf750fa to
80ee552
Compare
|
@whx-sjtu CI failure looks easy to fix. Just need to address the CustomOp changes in test code. |
80ee552 to
f7670e7
Compare
Yes. Working on it now. |
Reapplies #32331 that was reverted in #32725.
Purpose
First implementation of RFC #23786: Define PluggableLayer and apply to MLA as an example.
Test Plan
All ci should pass.
Test Result
All ci should pass.
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.