Revert "[PluggableLayer][1/N] Define PluggableLayer"#32725
Revert "[PluggableLayer][1/N] Define PluggableLayer"#32725robertgshaw2-redhat merged 1 commit intomainfrom
Conversation
This reverts commit 4ca62a0.
|
Documentation preview: https://vllm--32725.org.readthedocs.build/en/32725/ |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request effectively reverts the introduction of the PluggableLayer abstraction. The changes correctly remove the PluggableLayer class and its global registries, consolidating the op_registry and op_registry_oot within the CustomOp class as static attributes. References to PluggableLayer have been updated to CustomOp across the codebase, including the MultiHeadLatentAttentionWrapper which now correctly inherits from CustomOp and uses forward_native and forward_cuda methods. The documentation has also been updated to reflect these changes. The revert and subsequent refactoring appear to be clean and consistent.
github-actions
bot
added
the
ready
|
unfortunately, Im seeing some CI failures due to this PR. so just reverting while we check it out |
3 participants
Reverts #32331