Bugfix: Pass router logits dtype in nemotron shared experts#32669
Merged
tlrmchlsmth merged 2 commits intovllm-project:mainfrom Jan 29, 2026
Merged
Bugfix: Pass router logits dtype in nemotron shared experts#32669tlrmchlsmth merged 2 commits intovllm-project:mainfrom
tlrmchlsmth merged 2 commits intovllm-project:mainfrom
Conversation
Signed-off-by: Amir Klein <203507526+amirkl94@users.noreply.github.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request correctly fixes a dtype mismatch assertion in the MoE layer when data parallelism is enabled. The change introduces a router_logits_dtype variable, consistently using torch.float32 for the gating layer and the MoE implementation. This resolves the bug by ensuring dtype consistency for router logits. The fix is minimal, targeted, and well-implemented.
5 tasks
robertgshaw2-redhat
approved these changes
Jan 26, 2026
Collaborator
|
rebased for CI |
apd10
pushed a commit
to apd10/vllm
that referenced
this pull request
Jan 31, 2026
…ject#32669) Signed-off-by: Amir Klein <203507526+amirkl94@users.noreply.github.com>
PiratePai
pushed a commit
to PiratePai/epd_shm
that referenced
this pull request
Feb 3, 2026
…ject#32669) Signed-off-by: Amir Klein <203507526+amirkl94@users.noreply.github.com> Signed-off-by: PiratePai <416932041@qq.com> Signed-off-by: Pai <416932041@qq.com>
ItzDEXX
pushed a commit
to ItzDEXX/vllm
that referenced
this pull request
Feb 19, 2026
…ject#32669) Signed-off-by: Amir Klein <203507526+amirkl94@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
A change introduced in this PR , requires passing
router_logits_dtypeto MoE layer.When running with
dp > 1and flashinfer cutlass MoE kernel in nvfp4, the following error happens:Test Result
Verified no error happens when running with
dp > 1and flashinfer cutlass MoE kernel.