[Metrics] Complete removal of deprecated vllm:time_per_output_token_seconds metric#32661
Merged
markmc merged 1 commit intovllm-project:mainfrom Jan 20, 2026
Merged
Conversation
carlory
requested review from
DarkLight1337,
NickLucche,
aarnphm,
markmc and
robertgshaw2-redhat
as code owners
|
Documentation preview: https://vllm--32661.org.readthedocs.build/en/32661/ |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request completes the removal of the deprecated vllm:time_per_output_token_seconds metric. The changes are comprehensive, covering code, tests, documentation, and dashboard configurations. The deprecated metric is consistently replaced with vllm:inter_token_latency_seconds. The removal of the old metric's definition and observation logic in vllm/v1/metrics/loggers.py is clean. The corresponding test updates in tests/entrypoints/instrumentator/test_metrics.py correctly reflect this removal. The updates to Grafana and Perses dashboards, as well as the documentation, are also correct. The changes are well-executed and I have no issues to report.
…econds metric This commit completes the removal of the deprecated metrics that were: - Deprecated in v0.11 (replaced by vllm:inter_token_latency_seconds) - Hidden in v0.12 (behind --show-hidden-metrics-for-version=0.11 flag) - Completely removed in v0.13 (this commit) Changes: 1. Removed deprecated histogram definition from PrometheusStatLogger 2. Updated test files to use replacement metric vllm:inter_token_latency_seconds 3. Updated Grafana dashboard with replacement metric (10 references) 4. Updated Perses dashboard with replacement metric (10 references) 5. Updated design documentation to reflect current metrics The replacement metric vllm:inter_token_latency_seconds has identical functionality and bucket definitions. The different metric vllm:request_time_per_output_token_seconds is preserved as it is still actively used. Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com> Signed-off-by: carlory <baofa.fan@daocloud.io>
carlory
force-pushed
the
metrics-0-13-removal
branch
from
7d9f21f to
3c455d7
Compare
Member
This was referenced Jan 20, 2026
markmc
approved these changes
Jan 20, 2026
Contributor
Author
gopalsarda
pushed a commit
to gopalsarda/vllm
that referenced
this pull request
Jan 20, 2026
…econds metric (vllm-project#32661) This PR completes the removal of the deprecated vllm:time_per_output_token_seconds metric that was deprecated in v0.11, hidden in v0.12, scheduled for removal in v0.13, but delayed until v0.15. Signed-off-by: carlory <baofa.fan@daocloud.io> Co-authored-by: Claude Haiku 4.5 <noreply@anthropic.com>
dsuhinin
pushed a commit
to dsuhinin/vllm
that referenced
this pull request
Jan 21, 2026
…econds metric (vllm-project#32661) This PR completes the removal of the deprecated vllm:time_per_output_token_seconds metric that was deprecated in v0.11, hidden in v0.12, scheduled for removal in v0.13, but delayed until v0.15. Signed-off-by: carlory <baofa.fan@daocloud.io> Co-authored-by: Claude Haiku 4.5 <noreply@anthropic.com> Signed-off-by: dsuhinin <suhinin.dmitriy@gmail.com>
monajafi-amd
pushed a commit
to monajafi-amd/vllm
that referenced
this pull request
Jan 23, 2026
…econds metric (vllm-project#32661) This PR completes the removal of the deprecated vllm:time_per_output_token_seconds metric that was deprecated in v0.11, hidden in v0.12, scheduled for removal in v0.13, but delayed until v0.15. Signed-off-by: carlory <baofa.fan@daocloud.io> Co-authored-by: Claude Haiku 4.5 <noreply@anthropic.com> Signed-off-by: mohammad najafi <mohammad.najafi@amd.com>
lapy
pushed a commit
to lapy/vllm
that referenced
this pull request
Jan 27, 2026
…econds metric (vllm-project#32661) This PR completes the removal of the deprecated vllm:time_per_output_token_seconds metric that was deprecated in v0.11, hidden in v0.12, scheduled for removal in v0.13, but delayed until v0.15. Signed-off-by: carlory <baofa.fan@daocloud.io> Co-authored-by: Claude Haiku 4.5 <noreply@anthropic.com>
ItzDEXX
pushed a commit
to ItzDEXX/vllm
that referenced
this pull request
Feb 19, 2026
…econds metric (vllm-project#32661) This PR completes the removal of the deprecated vllm:time_per_output_token_seconds metric that was deprecated in v0.11, hidden in v0.12, scheduled for removal in v0.13, but delayed until v0.15. Signed-off-by: carlory <baofa.fan@daocloud.io> Co-authored-by: Claude Haiku 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR completes the removal of the deprecated
vllm:time_per_output_token_secondsmetric that was deprecated in v0.11, hidden in v0.12, and scheduled for removal in v0.13.Changes Made
1. Code Removal (vllm/v1/metrics/loggers.py)
2. Test Updates (tests/entrypoints/instrumentator/test_metrics.py)
vllm:inter_token_latency_seconds3. Dashboard Updates
vllm:inter_token_latency_secondsvllm:inter_token_latency_seconds4. Documentation
Test Validation
✅ Python syntax checks passed
✅ JSON validation passed
✅ YAML validation passed
✅ No deprecated metric references remain
✅ 34+ replacement metric references confirmed
Notes
vllm:request_time_per_output_token_seconds(different metric) preserved