[Cleanup] Remove deprecated vllm:time_per_output_token_seconds metric#31675
Closed
majiayu000 wants to merge 1 commit intovllm-project:mainfrom
Closed
[Cleanup] Remove deprecated vllm:time_per_output_token_seconds metric#31675majiayu000 wants to merge 1 commit intovllm-project:mainfrom
majiayu000 wants to merge 1 commit intovllm-project:mainfrom
Conversation
This metric was deprecated in v0.11 (renamed to vllm:inter_token_latency_seconds) and was marked for removal in v0.13.0 via the TODO comment. Since we are now at v0.14.x, this commit removes the deprecated metric and related code. Changes: - Remove histogram_time_per_output_token from PrometheusStatLogger - Remove related code in the record method - Update test_metrics.py to remove references to the deprecated metric Signed-off-by: majiayu000 <1835304752@qq.com>
majiayu000
requested review from
DarkLight1337,
NickLucche,
aarnphm,
markmc and
robertgshaw2-redhat
as code owners
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request removes the deprecated Prometheus metric vllm:time_per_output_token_seconds. The changes are well-contained and correctly remove the metric's definition, its usage in the code, and its presence in the test expectations. The code is cleaner as a result. The changes look good to me.
Collaborator
|
@markmc Would you like to take a look at this PR regarding the Prometheus metrics? Thanks! |
Member
|
Thank you, #32661 duplicates this but looks more comprehensive (e.g. updates dashboards) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
vllm:time_per_output_token_secondsPrometheus metricvllm:inter_token_latency_secondsis already availableTest plan