Skip to content

[CI] Add Helion as an optional dependency - #32482

Merged
yewentao256 merged 3 commits into
vllm-project:mainfrom
gmagogsfm:helion-optional-dep
Jan 19, 2026
Merged

yewentao256 merged 3 commits into
vllm-project:mainfrom
gmagogsfm:helion-optional-dep

Conversation

@gmagogsfm

@gmagogsfm gmagogsfm commented Jan 16, 2026

Copy link
Copy Markdown
Contributor

Related RFC

  • This PR adds PyTorch Helion as an optional dependency to vLLM, this allows future Helion-based development and testing
  • Developers can use pip install vllm[helion] to install vLLM variant with helion dependency
  • Added a new CI job for Helion kernel-related tests
  • Example import pattern
# Skip entire module if helion is not available
from vllm.utils.import_utils import has_helion
if not has_helion():
    pytest.skip(
        "Helion is not installed. Install with: pip install vllm[helion]",
        allow_module_level=True,
    )

import helion
import helion.language as hl

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces Helion as an optional dependency, adding the necessary setup in setup.py, a utility function for checking its availability, and a smoke test. The CI configuration has also been updated to include tests for Helion. While the changes are generally well-implemented, I've identified a couple of improvements for the CI job configurations. Specifically, they reference a non-existent directory and could better leverage the new vllm[helion] extra for installation. My review includes suggestions to address these points.

Comment thread .buildkite/test-amd.yaml Outdated
Comment thread .buildkite/test-amd.yaml
Comment thread .buildkite/test-pipeline.yaml Outdated
Comment thread .buildkite/test-pipeline.yaml
@gmagogsfm
gmagogsfm force-pushed the helion-optional-dep branch from 4307ddb to d4ffe08 Compare January 16, 2026 17:22
@gmagogsfm gmagogsfm changed the title Add Helion as an optional dependency [CI] Add Helion as an optional dependency Jan 16, 2026
@gmagogsfm

Copy link
Copy Markdown
Contributor Author

@zou3519 @ProExpertProg Please take a look, let me know if this is the correct way of adding optional dependencies in vLLM. Thanks

@ProExpertProg ProExpertProg left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This lookgs good to me, cc @mgoin @simon-mo for the release suffix

@zou3519 zou3519 added the ready ONLY add when PR is ready to merge/full CI is needed label Jan 16, 2026

@yewentao256 yewentao256 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the work!

@gmagogsfm
gmagogsfm force-pushed the helion-optional-dep branch from e8ae26d to 7ab2892 Compare January 16, 2026 22:31
Signed-off-by: Yanan Cao <gmagogsfm@gmail.com>
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

Signed-off-by: Yanan Cao <gmagogsfm@gmail.com>
@gmagogsfm
gmagogsfm force-pushed the helion-optional-dep branch from 7ab2892 to 1e9ca6e Compare January 17, 2026 02:22
@yewentao256
yewentao256 enabled auto-merge (squash) January 19, 2026 16:55
@yewentao256
yewentao256 merged commit 9d1e611 into vllm-project:main Jan 19, 2026
95 checks passed
gopalsarda pushed a commit to gopalsarda/vllm that referenced this pull request Jan 20, 2026
Signed-off-by: Yanan Cao <gmagogsfm@gmail.com>
lapy pushed a commit to lapy/vllm that referenced this pull request Jan 27, 2026
Signed-off-by: Yanan Cao <gmagogsfm@gmail.com>
mystous pushed a commit to mystous/vllm_hybrid that referenced this pull request May 10, 2026
Signed-off-by: Yanan Cao <gmagogsfm@gmail.com>
my-other-github-account pushed a commit to my-other-github-account/vllm that referenced this pull request May 15, 2026
Signed-off-by: Yanan Cao <gmagogsfm@gmail.com>
0826joyce pushed a commit to 0826joyce/vllm-serving-optimization that referenced this pull request May 19, 2026
Signed-off-by: Yanan Cao <gmagogsfm@gmail.com>
plasticchris pushed a commit to plasticchris/vllm that referenced this pull request Jul 20, 2026
Signed-off-by: Yanan Cao <gmagogsfm@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci/build ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants