[CI] Add Helion as an optional dependency - #32482
Conversation
There was a problem hiding this comment.
Code Review
This pull request introduces Helion as an optional dependency, adding the necessary setup in setup.py, a utility function for checking its availability, and a smoke test. The CI configuration has also been updated to include tests for Helion. While the changes are generally well-implemented, I've identified a couple of improvements for the CI job configurations. Specifically, they reference a non-existent directory and could better leverage the new vllm[helion] extra for installation. My review includes suggestions to address these points.
4307ddb to
d4ffe08
Compare
|
@zou3519 @ProExpertProg Please take a look, let me know if this is the correct way of adding optional dependencies in vLLM. Thanks |
yewentao256
left a comment
There was a problem hiding this comment.
LGTM, thanks for the work!
e8ae26d to
7ab2892
Compare
Signed-off-by: Yanan Cao <gmagogsfm@gmail.com>
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> Signed-off-by: Yanan Cao <gmagogsfm@gmail.com>
7ab2892 to
1e9ca6e
Compare
Signed-off-by: Yanan Cao <gmagogsfm@gmail.com>
Signed-off-by: Yanan Cao <gmagogsfm@gmail.com>
Signed-off-by: Yanan Cao <gmagogsfm@gmail.com>
Signed-off-by: Yanan Cao <gmagogsfm@gmail.com>
Signed-off-by: Yanan Cao <gmagogsfm@gmail.com>
Signed-off-by: Yanan Cao <gmagogsfm@gmail.com>
Related RFC
pip install vllm[helion]to install vLLM variant with helion dependency