Support configure skip_special_tokens in openai response api#32345
Merged
chaunceyjiang merged 1 commit intovllm-project:mainfrom Jan 15, 2026
Merged
Support configure skip_special_tokens in openai response api#32345chaunceyjiang merged 1 commit intovllm-project:mainfrom
chaunceyjiang merged 1 commit intovllm-project:mainfrom
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request adds support for configuring skip_special_tokens in the OpenAI-compatible response API. The change introduces the skip_special_tokens parameter to the ResponsesRequest model and correctly propagates it to the SamplingParams. The implementation is straightforward, follows existing patterns in the codebase, and the default value is consistent with other parts of the API. The change appears correct and I have no issues to report.
qandrew
approved these changes
Jan 15, 2026
chaunceyjiang
added
the
ready
Collaborator
|
fix #20874 (comment) |
sammysun0711
pushed a commit
to sammysun0711/vllm
that referenced
this pull request
Jan 16, 2026
…oject#32345) Signed-off-by: Shiyan Deng <dsy842974287@meta.com>
akh64bit
pushed a commit
to akh64bit/vllm
that referenced
this pull request
Jan 16, 2026
…oject#32345) Signed-off-by: Shiyan Deng <dsy842974287@meta.com>
dsuhinin
pushed a commit
to dsuhinin/vllm
that referenced
this pull request
Jan 21, 2026
…oject#32345) Signed-off-by: Shiyan Deng <dsy842974287@meta.com> Signed-off-by: dsuhinin <suhinin.dmitriy@gmail.com>
ItzDEXX
pushed a commit
to ItzDEXX/vllm
that referenced
this pull request
Feb 19, 2026
…oject#32345) Signed-off-by: Shiyan Deng <dsy842974287@meta.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Currently we always use default value which will skip decoding special tokens. Want to make it configurable.
Test Plan
Test Result
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.