Skip to content

[Frontend] OpenAI Responses API supports Tool/Function calling#20874

Closed
chaunceyjiang wants to merge 10 commits intovllm-project:mainfrom
chaunceyjiang:func_call
Closed

[Frontend] OpenAI Responses API supports Tool/Function calling#20874
chaunceyjiang wants to merge 10 commits intovllm-project:mainfrom
chaunceyjiang:func_call

Conversation

@chaunceyjiang
Copy link
Collaborator

@chaunceyjiang chaunceyjiang commented Jul 13, 2025

OpenAI Responses API supports Tool/Function calling

Follow up #20504

@github-actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @chaunceyjiang, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly extends the functionality of the OpenAI Responses API by adding support for tool and function calling. The changes involve modifying the request processing pipeline to interpret tool definitions, dynamically generating guided decoding constraints for model output, and restructuring the API response to include detailed function call information. This enables the system to leverage external tools and APIs through the language model's capabilities.

Highlights

  • Tool/Function Calling Support: Implemented comprehensive support for OpenAI-style tool/function calling within the Responses API, enabling the model to generate structured tool calls based on provided tool definitions and user prompts.
  • Dynamic Guided Decoding for Tools: Enhanced the guided decoding mechanism to dynamically generate JSON schemas for tool calls. This allows the model to be constrained to output valid JSON for function arguments, based on the tool_choice and tools parameters in the request.
  • Extended Response Format: Modified the ResponsesResponse output type to include ResponseFunctionToolCall objects. This ensures that the API can return structured information about the function calls generated by the model.
  • Tool Parsing Integration: Integrated a ToolParser to extract and format function calls from the model's generated output. This supports various tool_choice modes, including 'auto', 'required', and specific named function calls.
  • New Configuration Options: Introduced new configuration options (enable_auto_tools, expand_tools_even_if_tool_choice_none) to provide granular control over tool parsing behavior and how tool definitions are handled in the prompt.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@mergify
Copy link

mergify bot commented Jul 13, 2025

This pull request has merge conflicts that must be resolved before it can be
merged. Please rebase the PR, @chaunceyjiang.

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces Tool/Function calling support to the OpenAI Responses API. The changes involve protocol modifications, serving engine updates, and response serving logic enhancements. The review identifies a critical bug related to empty responses, a high-severity issue concerning data mutation, and some medium-severity issues regarding debug statements and type checking.

@mergify mergify bot added deepseek Related to DeepSeek models llama Related to Llama models v1 labels Jul 13, 2025
@mergify mergify bot added the documentation Improvements or additions to documentation label Jul 14, 2025
@chaunceyjiang chaunceyjiang marked this pull request as ready for review July 14, 2025 06:46
@chaunceyjiang chaunceyjiang requested a review from aarnphm as a code owner July 14, 2025 06:46
@chaunceyjiang chaunceyjiang force-pushed the func_call branch 2 times, most recently from 3df3811 to e59d75a Compare July 15, 2025 16:53
@mergify
Copy link

mergify bot commented Jul 16, 2025

This pull request has merge conflicts that must be resolved before it can be
merged. Please rebase the PR, @chaunceyjiang.

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

@mergify
Copy link

mergify bot commented Jul 24, 2025

This pull request has merge conflicts that must be resolved before it can be
merged. Please rebase the PR, @chaunceyjiang.

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

Signed-off-by: chaunceyjiang <chaunceyjiang@gmail.com>
Signed-off-by: chaunceyjiang <chaunceyjiang@gmail.com>
Signed-off-by: chaunceyjiang <chaunceyjiang@gmail.com>
Signed-off-by: chaunceyjiang <chaunceyjiang@gmail.com>
Signed-off-by: chaunceyjiang <chaunceyjiang@gmail.com>
Signed-off-by: chaunceyjiang <chaunceyjiang@gmail.com>
Signed-off-by: chaunceyjiang <chaunceyjiang@gmail.com>
Signed-off-by: chaunceyjiang <chaunceyjiang@gmail.com>
Signed-off-by: chaunceyjiang <chaunceyjiang@gmail.com>
@chaunceyjiang
Copy link
Collaborator Author

@aarnphm PTAL.

@mergify mergify bot removed the needs-rebase label Sep 8, 2025
@aarnphm
Copy link
Collaborator

aarnphm commented Sep 8, 2025

@aarnphm PTAL.

Yes will get to it tn

@mergify
Copy link

mergify bot commented Sep 10, 2025

This pull request has merge conflicts that must be resolved before it can be
merged. Please rebase the PR, @chaunceyjiang.

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

@mergify mergify bot added the needs-rebase label Sep 10, 2025
@madskildegaard
Copy link
Contributor

Hey, what's the status of this? Getting this essential feature in the Responses API would be great!

@chaunceyjiang
Copy link
Collaborator Author

Hey, what's the status of this? Getting this essential feature in the Responses API would be great!

@madskildegaard It may still take some time

@madskildegaard
Copy link
Contributor

Built tool/function call streaming on top of this branch, if anyone needs it

@mergify
Copy link

mergify bot commented Oct 8, 2025

Documentation preview: https://vllm--20874.org.readthedocs.build/en/20874/

@chaunceyjiang
Copy link
Collaborator Author

Built chaunceyjiang#1 on top of this branch, if anyone needs it

Hi, @madskildegaard Could you resubmit your PR?

@chaunceyjiang
Copy link
Collaborator Author

chaunceyjiang commented Dec 3, 2025

Hi, @madskildegaard . I’ve submitted the contribution as a new PR #29947 and will include you as a co-author.

@madskildegaard
Copy link
Contributor

Built chaunceyjiang#1 on top of this branch, if anyone needs it

Hi, @madskildegaard Could you resubmit your PR?

Hi @chaunceyjiang, it would probably need a few changes to be up-to-date with main branch, but I can look into it if you want.

Hi, @PedroMiolaSilva. I’ve submitted the contribution as a new PR #29947 and will include you as a co-author.

I suppose this comment was meant to be for me?

@chaunceyjiang
Copy link
Collaborator Author

@madskildegaard Yes. ❤️

@madskildegaard
Copy link
Contributor

@chaunceyjiang, I see you already made some changes in the new draft to make it more up-to-date. Will you finish the draft yourself or do you want me to take a look if anything else needs be changed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

deepseek Related to DeepSeek models documentation Improvements or additions to documentation frontend llama Related to Llama models needs-rebase tool-calling v1

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

6 participants