[CI] [Bugfix] Fix unbounded variable in run-multi-node-test.sh#31967
Merged
vllm-bot merged 2 commits intovllm-project:mainfrom Jan 8, 2026
Merged
[CI] [Bugfix] Fix unbounded variable in run-multi-node-test.sh#31967vllm-bot merged 2 commits intovllm-project:mainfrom
run-multi-node-test.sh#31967vllm-bot merged 2 commits intovllm-project:mainfrom
Conversation
Signed-off-by: tjtanaa <tunjian.tan@embeddedllm.com>
tjtanaa
added
rocm
tjtanaa
changed the title
run-multi-node-test.sh
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request addresses a bug in a multi-node test script and enhances the CI configuration. The change in .buildkite/test-pipeline.yaml adds .buildkite/scripts/run-multi-node-test.sh to the paths list for the multi-node test job. This is a good practice, ensuring that future modifications to this script will trigger the relevant CI job for validation. The change is correct and improves the CI pipeline's robustness.
Signed-off-by: tjtanaa <tunjian.tan@embeddedllm.com>
DarkLight1337
approved these changes
Jan 8, 2026
yugong333
pushed a commit
to yugong333/vllm
that referenced
this pull request
Jan 9, 2026
…m-project#31967) Signed-off-by: tjtanaa <tunjian.tan@embeddedllm.com>
akh64bit
pushed a commit
to akh64bit/vllm
that referenced
this pull request
Jan 16, 2026
…m-project#31967) Signed-off-by: tjtanaa <tunjian.tan@embeddedllm.com>
dsuhinin
pushed a commit
to dsuhinin/vllm
that referenced
this pull request
Jan 21, 2026
…m-project#31967) Signed-off-by: tjtanaa <tunjian.tan@embeddedllm.com> Signed-off-by: dsuhinin <suhinin.dmitriy@gmail.com>
ItzDEXX
pushed a commit
to ItzDEXX/vllm
that referenced
this pull request
Feb 19, 2026
…m-project#31967) Signed-off-by: tjtanaa <tunjian.tan@embeddedllm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Fix the issue
./.buildkite/scripts/run-multi-node-test.sh: line 10: ROCM_HOME: unbound variableafter PR #31922 .https://buildkite.com/vllm/ci/builds/46115/steps/canvas?sid=019b9d2c-bfc3-4c47-b214-3bf7def2f86a
Add
.buildkite/scripts/run-multi-node-test.shintotest-pipeline.ymlto trigger during CI.Test Plan
Pass CI.
Test Result
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.