[CI] fix ROCM_HOME: unbound variable#31953
Closed
LucasWilkinson wants to merge 1 commit intovllm-project:mainfrom
Closed
[CI] fix ROCM_HOME: unbound variable#31953LucasWilkinson wants to merge 1 commit intovllm-project:mainfrom
LucasWilkinson wants to merge 1 commit intovllm-project:mainfrom
Conversation
LucasWilkinson
added
the
ready
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request fixes an 'unbound variable' error in the run-multi-node-test.sh script that occurred when the ROCM_HOME environment variable was not set. The change uses the ${ROCM_HOME:-} parameter expansion to provide a default empty value if the variable is unset, which correctly resolves the issue under set -u. The fix is correct and appropriate.
Collaborator
Author
|
superseded by: #31967 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#31922 broke the "2 Node Tests (4 GPUs in total)" with
https://buildkite.com/organizations/vllm/pipelines/ci/builds/46074/jobs/019b9c75-6389-40dc-a23b-5ecd3683d951/log