Skip to content

[Chore]: Remove HF format Phi4-MM examples#31405

Merged
DarkLight1337 merged 1 commit intovllm-project:mainfrom
Isotr0py:rm-phi4-multimodal
Dec 27, 2025
Merged

[Chore]: Remove HF format Phi4-MM examples#31405
DarkLight1337 merged 1 commit intovllm-project:mainfrom
Isotr0py:rm-phi4-multimodal

Conversation

@Isotr0py
Copy link
Member

@Isotr0py Isotr0py commented Dec 27, 2025

Purpose

Test Plan

Test Result


Essential Elements of an Effective PR Description Checklist
  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.
  • (Optional) Release notes update. If your change is user facing, please update the release notes draft in the Google Doc.

Signed-off-by: Isotr0py <mozf@mail2.sysu.edu.cn>
@mergify
Copy link

mergify bot commented Dec 27, 2025

Documentation preview: https://vllm--31405.org.readthedocs.build/en/31405/

@mergify mergify bot added the documentation Improvements or additions to documentation label Dec 27, 2025
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly removes the deprecated phi4_multimodal example code from audio_language.py, vision_language.py, and vision_language_multi_image.py. The changes consist of straightforward deletions of the relevant functions and their corresponding entries in the model maps. These removals are consistent across all affected files and align with the PR's stated purpose. The changes are clean and I see no issues.

@DarkLight1337 DarkLight1337 enabled auto-merge (squash) December 27, 2025 12:46
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Dec 27, 2025
@DarkLight1337 DarkLight1337 merged commit 40a8756 into vllm-project:main Dec 27, 2025
21 checks passed
@Isotr0py Isotr0py deleted the rm-phi4-multimodal branch December 27, 2025 14:21
yiliu30 pushed a commit to yiliu30/vllm-fork that referenced this pull request Dec 30, 2025
Signed-off-by: Isotr0py <mozf@mail2.sysu.edu.cn>
dsuhinin pushed a commit to dsuhinin/vllm that referenced this pull request Jan 21, 2026
Signed-off-by: Isotr0py <mozf@mail2.sysu.edu.cn>
Signed-off-by: dsuhinin <suhinin.dmitriy@gmail.com>
ItzDEXX pushed a commit to ItzDEXX/vllm that referenced this pull request Feb 19, 2026
Signed-off-by: Isotr0py <mozf@mail2.sysu.edu.cn>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants