Delete HF version of Phi 4 MM#30049
Conversation
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
|
Documentation preview: https://vllm--30049.org.readthedocs.build/en/30049/ |
There was a problem hiding this comment.
Code Review
This pull request removes support for the Hugging Face Transformers version of the Phi 4 multimodal model (Phi4MultimodalForCausalLM). The changes are consistent and well-executed, covering the model implementation, its registration in various registries, associated tests, and documentation. The removal is clean and complete within the scope of the provided files, with no apparent dangling references. Overall, this is a solid cleanup effort.
|
Sorry @Isotr0py, I know you put a lot of work into this implementation 😢 |
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
|
Good suggestion, we'll make a community repo so that at least the Transformers implementation is usable in Transformers without needing to specify a ref. |
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com> Signed-off-by: dsuhinin <suhinin.dmitriy@gmail.com>
Phi 4 multimodal is currently compatible with vLLM in 2 ways:
Phi4MMForCausalLM- reimplemented in vLLM based on Microsoft's custom code from https://huggingface.co/microsoft/Phi-4-multimodal-instructPhi4MultimodalForCausalLM- reimplemented in vLLM based on Huigging Face Transformers (requires https://huggingface.co/microsoft/Phi-4-multimodal-instruct/discussions/70)Given that:
We have decided to drop support for the Transformers implementation in vLLM.
This means that:
--trust-remote-code