[CI] Reorganization pooling_mteb_test#31265
Conversation
There was a problem hiding this comment.
Code Review
This pull request is a well-executed refactoring of the MTEB pooling tests. The key changes include splitting mteb_utils.py into more focused mteb_embed_utils.py and mteb_score_utils.py files, which improves code organization. Additionally, the removal of specialized CLSPoolingModelInfo and LASTPoolingModelInfo classes in favor of adding explicit configuration fields like pooling_type, attn_type, is_prefix_caching_supported, and is_chunked_prefill_supported to the base ModelInfo and RerankModelInfo dataclasses is a significant improvement. This makes the test configurations clearer and more explicit. The tests have been updated to assert these new properties, which enhances the test coverage for model configurations. Overall, these changes improve the clarity, maintainability, and robustness of the test suite. The refactoring appears solid, and I found no issues.
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
Signed-off-by: wang.yuqi <noooop@126.com>
Signed-off-by: wang.yuqi <noooop@126.com> Signed-off-by: dsuhinin <suhinin.dmitriy@gmail.com>
Signed-off-by: wang.yuqi <noooop@126.com>
Purpose
Following #26623, we test pooling_type, attn_type, is_prefix_caching_supported, is_chunked_prefill_supported
Test Plan
tests/models/language/pooling_mteb_test/
tests/entrypoints/pooling/
Test Result
pass
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.