Skip to content

Improve enable chunked_prefill & prefix_caching logic.#26623

Merged
vllm-bot merged 72 commits intovllm-project:mainfrom
noooop:chunked_prefill_logic
Nov 28, 2025
Merged

Improve enable chunked_prefill & prefix_caching logic.#26623
vllm-bot merged 72 commits intovllm-project:mainfrom
noooop:chunked_prefill_logic

Conversation

@noooop
Copy link
Collaborator

@noooop noooop commented Oct 11, 2025

Purpose

Improve enable chunked_prefill & prefix_caching logic.

Test Plan

pytest -s -vvv tests/test_config.py::test_is_chunked_prefill_supported
pytest -s -vvv tests/test_config.py::test_is_prefix_caching_supported
pytest -s -vvv tests/models/language/pooling/test_auto_prefix_cache_support.py

Test Result

pass


Essential Elements of an Effective PR Description Checklist
  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.
  • (Optional) Release notes update. If your change is user facing, please update the release notes draft in the Google Doc.

@noooop noooop changed the title [Model][0/N] Improve all pooling task | Improve enable chunked_prefill & prefix_caching logic. [Model][4/N] Improve all pooling task | Improve enable chunked_prefill & prefix_caching logic. Oct 11, 2025
@noooop noooop changed the title [Model][4/N] Improve all pooling task | Improve enable chunked_prefill & prefix_caching logic. [Model][5/N] Improve all pooling task | Improve enable chunked_prefill & prefix_caching logic. Oct 14, 2025
@noooop noooop changed the title [Model][5/N] Improve all pooling task | Improve enable chunked_prefill & prefix_caching logic. [Model][6/N] Improve all pooling task | Improve enable chunked_prefill & prefix_caching logic. Oct 17, 2025
@noooop noooop changed the title [Model][6/N] Improve all pooling task | Improve enable chunked_prefill & prefix_caching logic. [Model][7/N] Improve all pooling task | Improve enable chunked_prefill & prefix_caching logic. Nov 11, 2025
Signed-off-by: wang.yuqi <yuqi.wang@daocloud.io>
@noooop noooop force-pushed the chunked_prefill_logic branch from c8e46f4 to aa55dab Compare November 18, 2025 03:37
@noooop noooop changed the title [Model][7/N] Improve all pooling task | Improve enable chunked_prefill & prefix_caching logic. [Model] Improve enable chunked_prefill & prefix_caching logic. Nov 20, 2025
Signed-off-by: wang.yuqi <yuqi.wang@daocloud.io>
@noooop noooop marked this pull request as ready for review November 20, 2025 10:41
@noooop noooop requested a review from WoosukKwon as a code owner November 20, 2025 10:41
Signed-off-by: wang.yuqi <yuqi.wang@daocloud.io>
@mergify mergify bot removed the needs-rebase label Nov 27, 2025
@DarkLight1337 DarkLight1337 enabled auto-merge (squash) November 27, 2025 10:04
noooop and others added 2 commits November 27, 2025 18:08
Signed-off-by: wang.yuqi <yuqi.wang@daocloud.io>
Copy link
Contributor

@nwaughachukwuma nwaughachukwuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing an excellent job here.

However, there're so many not-too-related changes in this PR across multiple touch points. To make reviewing and merging faster, please break this down into multiple PRs, each with relative changes.

Thank you.

noooop and others added 4 commits November 27, 2025 20:57
Signed-off-by: wang.yuqi <noooop@126.com>
Signed-off-by: wang.yuqi <noooop@126.com>
Signed-off-by: wang.yuqi <noooop@126.com>
@noooop
Copy link
Collaborator Author

noooop commented Nov 27, 2025

However, there're so many not-too-related changes in this PR across multiple touch points. To make reviewing and merging faster, please break this down into multiple PRs, each with relative changes.

Yes, this PR touches many files, but they're all relevant.

noooop and others added 5 commits November 27, 2025 21:13
Signed-off-by: wang.yuqi <noooop@126.com>
Signed-off-by: wang.yuqi <noooop@126.com>
Signed-off-by: wang.yuqi <yuqi.wang@daocloud.io>
@vllm-bot vllm-bot merged commit f4b7605 into vllm-project:main Nov 28, 2025
54 of 56 checks passed
@noooop noooop deleted the chunked_prefill_logic branch November 28, 2025 06:06
kitaekatt pushed a commit to kitaekatt/vllm that referenced this pull request Dec 1, 2025
…26623)

Signed-off-by: wang.yuqi <yuqi.wang@daocloud.io>
Signed-off-by: wang.yuqi <noooop@126.com>
Co-authored-by: Cyrus Leung <tlleungac@connect.ust.hk>
amd-hhashemi pushed a commit to amd-hhashemi/vllm that referenced this pull request Dec 2, 2025
…26623)

Signed-off-by: wang.yuqi <yuqi.wang@daocloud.io>
Signed-off-by: wang.yuqi <noooop@126.com>
Co-authored-by: Cyrus Leung <tlleungac@connect.ust.hk>
Signed-off-by: Hashem Hashemi <hashem.hashemi@amd.com>
dsuhinin pushed a commit to dsuhinin/vllm that referenced this pull request Jan 21, 2026
…26623)

Signed-off-by: wang.yuqi <yuqi.wang@daocloud.io>
Signed-off-by: wang.yuqi <noooop@126.com>
Co-authored-by: Cyrus Leung <tlleungac@connect.ust.hk>
Signed-off-by: dsuhinin <suhinin.dmitriy@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

new-model Requests to new models ready ONLY add when PR is ready to merge/full CI is needed v1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants