Skip to content

[AMD][CI] fix lm eval ci arg#30911

Merged
tjtanaa merged 2 commits intovllm-project:mainfrom
divakar-amd:fix_ci_test_eval
Dec 18, 2025
Merged

[AMD][CI] fix lm eval ci arg#30911
tjtanaa merged 2 commits intovllm-project:mainfrom
divakar-amd:fix_ci_test_eval

Conversation

@divakar-amd
Copy link
Contributor

@divakar-amd divakar-amd commented Dec 17, 2025

Fixing args for AMD-CI run in accordance with #30723

This fixes the following tests for AMD-CI:

LM Eval Small Models
LM Eval Small Models (1 Card)

Signed-off-by: Divakar Verma <divakar.verma@amd.com>
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the AMD CI configuration by removing the --tp-size=1 argument from three pytest commands. According to the description, this is intended to fix the LM Eval Small Models and LM Eval Small Models (1 Card) tests for AMD-CI. The changes are consistent across the different test steps in .buildkite/test-amd.yaml and appear to be a straightforward fix for the CI pipeline. I have not identified any issues with these changes.

@mergify mergify bot added ci/build rocm Related to AMD ROCm labels Dec 17, 2025
Copy link
Collaborator

@tjtanaa tjtanaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tjtanaa tjtanaa added the ready ONLY add when PR is ready to merge/full CI is needed label Dec 18, 2025
@tjtanaa tjtanaa merged commit 82dc338 into vllm-project:main Dec 18, 2025
16 of 17 checks passed
yugong333 pushed a commit to yugong333/vllm that referenced this pull request Dec 22, 2025
Signed-off-by: Divakar Verma <divakar.verma@amd.com>
Majid-Taheri pushed a commit to Majid-Taheri/vllm that referenced this pull request Dec 23, 2025
Signed-off-by: Divakar Verma <divakar.verma@amd.com>
Signed-off-by: Ubuntu <mjtaheri68@gmail.com>
dsuhinin pushed a commit to dsuhinin/vllm that referenced this pull request Jan 21, 2026
Signed-off-by: Divakar Verma <divakar.verma@amd.com>
Signed-off-by: dsuhinin <suhinin.dmitriy@gmail.com>
ItzDEXX pushed a commit to ItzDEXX/vllm that referenced this pull request Feb 19, 2026
Signed-off-by: Divakar Verma <divakar.verma@amd.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci/build ready ONLY add when PR is ready to merge/full CI is needed rocm Related to AMD ROCm

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants