[Bugfix] Fix wrong mock attribute#29704
Merged
DarkLight1337 merged 1 commit intovllm-project:mainfrom Nov 29, 2025
Merged
Conversation
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
DarkLight1337
requested review from
NickLucche,
aarnphm and
robertgshaw2-redhat
as code owners
DarkLight1337
added
the
ready
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request correctly fixes a bug in the MockEngine test utility. The attribute processor was renamed to input_processor, resolving an AttributeError that was causing test failures. The change is accurate and addresses the issue effectively. I have no further suggestions.
jeejeelee
approved these changes
Nov 29, 2025
5 tasks
kitaekatt
pushed a commit
to kitaekatt/vllm
that referenced
this pull request
Dec 1, 2025
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
amd-hhashemi
pushed a commit
to amd-hhashemi/vllm
that referenced
this pull request
Dec 2, 2025
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk> Signed-off-by: Hashem Hashemi <hashem.hashemi@amd.com>
dsuhinin
pushed a commit
to dsuhinin/vllm
that referenced
this pull request
Jan 21, 2026
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk> Signed-off-by: dsuhinin <suhinin.dmitriy@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
FIX https://buildkite.com/vllm/ci/builds/41118/steps/canvas?jid=019acc26-966b-4be3-96f9-5c52a83e0135#019acc26-966b-4be3-96f9-5c52a83e0135 caused by #29682
The PR was merged because the test failure was hidden by the flaky GPT-OSS test
Test Plan
Test Result
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.