[Chore] Rename Processor to InputProcessor#29682
Conversation
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
There was a problem hiding this comment.
Code Review
This pull request is a refactoring that renames the Processor class to InputProcessor to improve clarity and avoid naming conflicts. The changes are applied consistently across the codebase, including in tests, engine components, and entrypoints. A new file vllm/v1/engine/input_processor.py is introduced, and the old vllm/v1/engine/processor.py is converted into a backward-compatibility shim that issues a DeprecationWarning. This is a good practice for managing such refactorings. The changes appear correct and thorough. I have not found any issues of high or critical severity.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
|
Flaky test |
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk> Signed-off-by: Hashem Hashemi <hashem.hashemi@amd.com>
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk> Signed-off-by: dsuhinin <suhinin.dmitriy@gmail.com>
Purpose
Avoid confusion with
IOProcessorandOutputProcessor, and also with HF's ownAutoProcessorclasses. Later on,Rendererwill probably contain bothInputProcessorandIOProcessor.This PR keeps back-compatibility for the old import in case people with custom engines use it.
Test Plan
Test Result
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.