Skip to content

[Misc] Fix wrong comment in scheduler #28880

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 17, 2025
Merged

[Misc] Fix wrong comment in scheduler #28880

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
762b2c7
[Misc] Fix wrong comment in scheduler
zhuohan123 Nov 17, 2025
4c298a7
fix
zhuohan123 Nov 17, 2025
9c83231
Fix indentation in scheduler.py for else statement
zhuohan123 Nov 17, 2025
427756b
Update scheduler.py
zhuohan123 Nov 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions vllm/v1/core/sched/scheduler.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -472,9 +472,9 @@ def schedule(self) -> SchedulerOutput:
num_computed_tokens = (
num_new_local_computed_tokens + num_external_computed_tokens
)
# KVTransfer: WAITING reqs have num_computed_tokens > 0
# after async KV recvs are completed.
else:
# KVTransfer: WAITING reqs have num_computed_tokens > 0
# after async KV recvs are completed.
new_computed_blocks = self.kv_cache_manager.empty_kv_cache_blocks
num_new_local_computed_tokens = 0
num_computed_tokens = request.num_computed_tokens
Expand All @@ -483,12 +483,12 @@ def schedule(self) -> SchedulerOutput:
external_load_encoder_input = []
new_encoder_compute_budget = encoder_compute_budget

# KVTransfer: loading remote KV, do not allocate for new work.
if load_kv_async:
# KVTransfer: loading remote KV, do not allocate for new work.
assert num_external_computed_tokens > 0
num_new_tokens = 0
# Number of tokens to be scheduled.
else:
# Number of tokens to be scheduled.
# We use `request.num_tokens` instead of
# `request.num_prompt_tokens` to consider the resumed
# requests, which have output tokens.
Expand Down
Loading