[Misc] Fix wrong comment in scheduler #28880
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Zhuohan Li <[email protected]>
zhuohan123
requested review from
ApostaC,
WoosukKwon,
alexm-redhat,
heheda12345,
njhill,
robertgshaw2-redhat and
ywang96
as code owners
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request correctly moves two comments within the scheduler's schedule method to better align with the code blocks they describe. This improves code readability and clarity. The change is a good, minor improvement, and I see no issues with it.
Signed-off-by: Zhuohan Li <[email protected]>
Signed-off-by: Zhuohan Li <[email protected]>
Signed-off-by: Zhuohan Li <[email protected]>
robertgshaw2-redhat
approved these changes
Nov 17, 2025
github-actions
bot
added
the
ready
WoosukKwon
approved these changes
Nov 17, 2025
Collaborator
WoosukKwon
left a comment
WoosukKwon
left a comment
There was a problem hiding this comment.
I see that some folks like commenting above if and else, but it’s not really my preference, so let’s tidy this up.
yewentao256
approved these changes
Nov 17, 2025
Member
yewentao256
left a comment
yewentao256
left a comment
There was a problem hiding this comment.
LGTM, thanks for the work!
Victor49152
pushed a commit
to Victor49152/vllm
that referenced
this pull request
Nov 20, 2025
Signed-off-by: Zhuohan Li <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Nit: Fix wrong comment in scheduler.
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.