[NIXL][XPU] update install script of NIXL#28778
[NIXL][XPU] update install script of NIXL#28778jikunshang merged 2 commits intovllm-project:mainfrom
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the installation script for NIXL and pins its version in the Dockerfile. The changes aim to improve the build process by using rpath to locate shared libraries, which is a good practice. However, I've found a critical issue in how the rpath is being set in the installation script, which will likely cause runtime failures. My review includes a suggested fix for this issue.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Signed-off-by: zhenwei-intel <zhenwei.liu@intel.com>
zhenwei-intel
force-pushed
the
update_xpu_nixl
branch
from
7b8d9f4 to
9ee46b6
Compare
| libxext6 \ | ||
| libgl1 \ | ||
| lsb-release \ | ||
| libaio-dev \ |
There was a problem hiding this comment.
what's this for? if nixl have libaio dependency, I am not sure whether this is a good manner since version may matter.
There was a problem hiding this comment.
which is needed by nixl v0.7.1
github-actions
bot
added
the
ready
Signed-off-by: zhenwei-intel <zhenwei.liu@intel.com>
Signed-off-by: zhenwei-intel <zhenwei.liu@intel.com>
2 participants
update install script of NIXL
pin to 0.7.0 in dockerfile