Repository navigation
[ROCm][Bugfix] Revert removing setuptools version restriction - #28592
Conversation
…to run python setup.py develop Signed-off-by: Gregory Shtrasberg <Gregory.Shtrasberg@amd.com>
There was a problem hiding this comment.
Code Review
This pull request correctly reverts the setuptools version restriction to <80.0.0 for ROCm-specific files to fix a build issue. My review points out that this fix should be applied more broadly to other requirement files and the pyproject.toml to ensure consistency and prevent similar build failures on other platforms, as hinted in the pull request description.
| cmake>=3.26.1,<4 | ||
| packaging>=24.2 | ||
| setuptools>=77.0.3,<81.0.0 | ||
| setuptools>=77.0.3,<80.0.0 |
There was a problem hiding this comment.
While this change correctly pins setuptools to <80.0.0 for ROCm builds, several other files still allow versions up to <81.0.0. As noted in the PR description, this could lead to the same build issues on other platforms. For consistency and to prevent potential failures, it's recommended to apply this version restriction more broadly.
The following files also contain setuptools<81.0.0 and should likely be updated to <80.0.0:
pyproject.toml(line 7)requirements/build.txt(line 5)requirements/common.txt(line 38)requirements/cpu-build.txt(line 4)requirements/xpu.txt(line 8)
…roject#28592) Signed-off-by: Gregory Shtrasberg <Gregory.Shtrasberg@amd.com> Signed-off-by: George D. Torres <gdavtor@gmail.com>
…roject#28592) Signed-off-by: Gregory Shtrasberg <Gregory.Shtrasberg@amd.com>
…roject#28592) Signed-off-by: Gregory Shtrasberg <Gregory.Shtrasberg@amd.com>
…roject#28592) Signed-off-by: Gregory Shtrasberg <Gregory.Shtrasberg@amd.com>
…roject#28592) Signed-off-by: Gregory Shtrasberg <Gregory.Shtrasberg@amd.com>
…roject#28592) Signed-off-by: Gregory Shtrasberg <Gregory.Shtrasberg@amd.com>
Drop the setuptools >=83 change from this PR. The <80/<81 caps remain for ROCm editable installs and CMake build-dir reuse (see vllm-project#17320, vllm-project#28592). Keep pyjwt >=2.14.0 and rand 0.9.3+ only. Co-authored-by: Cursor <cursoragent@cursor.com> Signed-off-by: Juan Pérez de Algaba <jperezde@redhat.com>
Reverting #28337 on ROCm specific files until a proper solution is found. Other platforms might suffer from a similar issue
The underlying issue mentioned in #17320 is still not fixed properly.
To elaborate, setuptools>=80 will replace
python setup.py developwithpip install -e ., which creates an isolateb build environment and pulls build dependencies from pyprojec.toml. In particulat it would try to install torch==2.9.0, which is a CUDA version of torch package by default, so the ROCm build would fail.The only possible way to build currently is with bdist_wheel, which doesn't allow creating a development environment