Skip to content

[ROCm][Bugfix] Revert removing setuptools version restriction - #28592

Merged
tjtanaa merged 1 commit into
vllm-project:mainfrom
ROCm:setuptools_version
Nov 13, 2025
Merged

tjtanaa merged 1 commit into
vllm-project:mainfrom
ROCm:setuptools_version

Conversation

@gshtras

@gshtras gshtras commented Nov 12, 2025 •

Copy link
Copy Markdown
Contributor

Reverting #28337 on ROCm specific files until a proper solution is found. Other platforms might suffer from a similar issue

The underlying issue mentioned in #17320 is still not fixed properly.
To elaborate, setuptools>=80 will replace python setup.py develop with pip install -e ., which creates an isolateb build environment and pulls build dependencies from pyprojec.toml. In particulat it would try to install torch==2.9.0, which is a CUDA version of torch package by default, so the ROCm build would fail.
The only possible way to build currently is with bdist_wheel, which doesn't allow creating a development environment

…to run python setup.py develop

Signed-off-by: Gregory Shtrasberg <Gregory.Shtrasberg@amd.com>
@gshtras
gshtras requested a review from tjtanaa as a code owner November 12, 2025 21:58
@mergify mergify Bot added ci/build rocm Related to AMD ROCm labels Nov 12, 2025

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly reverts the setuptools version restriction to <80.0.0 for ROCm-specific files to fix a build issue. My review points out that this fix should be applied more broadly to other requirement files and the pyproject.toml to ensure consistency and prevent similar build failures on other platforms, as hinted in the pull request description.

cmake>=3.26.1,<4
packaging>=24.2
setuptools>=77.0.3,<81.0.0
setuptools>=77.0.3,<80.0.0

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

While this change correctly pins setuptools to <80.0.0 for ROCm builds, several other files still allow versions up to <81.0.0. As noted in the PR description, this could lead to the same build issues on other platforms. For consistency and to prevent potential failures, it's recommended to apply this version restriction more broadly.

The following files also contain setuptools<81.0.0 and should likely be updated to <80.0.0:

  • pyproject.toml (line 7)
  • requirements/build.txt (line 5)
  • requirements/common.txt (line 38)
  • requirements/cpu-build.txt (line 4)
  • requirements/xpu.txt (line 8)

@tjtanaa tjtanaa left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tjtanaa tjtanaa added the ready ONLY add when PR is ready to merge/full CI is needed label Nov 12, 2025
@tjtanaa
tjtanaa enabled auto-merge (squash) November 12, 2025 22:41
@tjtanaa
tjtanaa merged commit d75ad04 into vllm-project:main Nov 13, 2025
23 of 24 checks passed
@gshtras
gshtras deleted the setuptools_version branch November 13, 2025 17:03
geodavic pushed a commit to geodavic/vllm that referenced this pull request Nov 16, 2025
…roject#28592)

Signed-off-by: Gregory Shtrasberg <Gregory.Shtrasberg@amd.com>
Signed-off-by: George D. Torres <gdavtor@gmail.com>
devpatelio pushed a commit to SumanthRH/vllm that referenced this pull request Nov 29, 2025
…roject#28592)

Signed-off-by: Gregory Shtrasberg <Gregory.Shtrasberg@amd.com>
mystous pushed a commit to mystous/vllm_hybrid that referenced this pull request May 10, 2026
…roject#28592)

Signed-off-by: Gregory Shtrasberg <Gregory.Shtrasberg@amd.com>
my-other-github-account pushed a commit to my-other-github-account/vllm that referenced this pull request May 15, 2026
…roject#28592)

Signed-off-by: Gregory Shtrasberg <Gregory.Shtrasberg@amd.com>
0826joyce pushed a commit to 0826joyce/vllm-serving-optimization that referenced this pull request May 19, 2026
…roject#28592)

Signed-off-by: Gregory Shtrasberg <Gregory.Shtrasberg@amd.com>
plasticchris pushed a commit to plasticchris/vllm that referenced this pull request Jul 20, 2026
…roject#28592)

Signed-off-by: Gregory Shtrasberg <Gregory.Shtrasberg@amd.com>
jperezdealgaba added a commit to jperezdealgaba/vllm that referenced this pull request Sep 30, 2026
Drop the setuptools >=83 change from this PR. The <80/<81 caps remain
for ROCm editable installs and CMake build-dir reuse (see vllm-project#17320,
vllm-project#28592). Keep pyjwt >=2.14.0 and rand 0.9.3+ only.

Co-authored-by: Cursor <cursoragent@cursor.com>
Signed-off-by: Juan Pérez de Algaba <jperezde@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci/build ready ONLY add when PR is ready to merge/full CI is needed rocm Related to AMD ROCm

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants