Skip to content

[Build][Bugfix] Restrict setuptools version to <80 - #17320

Merged
vllm-bot merged 1 commit into
vllm-project:mainfrom
ROCm:setuptools_version
Apr 29, 2025
Merged

[Build][Bugfix] Restrict setuptools version to <80#17320
vllm-bot merged 1 commit into
vllm-project:mainfrom
ROCm:setuptools_version

Conversation

@gshtras

@gshtras gshtras commented Apr 28, 2025 •
edited by github-actions Bot
Loading

Copy link
Copy Markdown
Contributor

Setuptools appears to have introduced a bug in v80.0.0 resulting in a crash when trying to run python setup.py develop with a --prefix
Original issue filed at pypa/setuptools#4966
Until it is addressed we should restrict the version
This is a generalization of #17298

Another issue is that v80 will replace python setup.py develop with pip install -e . which does not work with ROCm, in part due to torch requirement hard coded in pyproject.toml

@gshtras
Restrict setuptools version
2e80001 
Signed-off-by: Gregory Shtrasberg <Gregory.Shtrasberg@amd.com>
@github-actions

github-actions Bot commented Apr 28, 2025

Copy link
Copy Markdown

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@mergify mergify Bot added the ci/build label Apr 28, 2025
gshtras added a commit to ROCm/vllm that referenced this pull request Apr 28, 2025
@gshtras
Restrict setuptools version
9dc502a 
Early access to vllm-project#17320
setuptools v80 broke too many things
@gshtras gshtras mentioned this pull request Apr 28, 2025
Merged
gshtras added a commit to ROCm/vllm that referenced this pull request Apr 28, 2025
@gshtras
Restrict setuptools version (#529)
1fbb019 
* Restrict setuptools version

Early access to vllm-project#17320
setuptools v80 broke too many things

* Update Dockerfile.rocm_base
@WoosukKwon WoosukKwon added the ready ONLY add when PR is ready to merge/full CI is needed label Apr 29, 2025
WoosukKwon
WoosukKwon approved these changes Apr 29, 2025
View reviewed changes

@WoosukKwon WoosukKwon left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@WoosukKwon
WoosukKwon enabled auto-merge (squash) April 29, 2025 01:08
@aarnphm

aarnphm commented Apr 29, 2025

Copy link
Copy Markdown
Contributor

I think we should lock setuptools to an exact version, instead of upper bound

@vllm-bot
vllm-bot merged commit 4464109 into vllm-project:main Apr 29, 2025
@DarkLight1337

DarkLight1337 commented Apr 29, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

I think we should lock setuptools to an exact version, instead of upper bound

IMO having an upper bound better communicates the problem associated with v80 since we can directly read the problematic version from the file without having to guess why the version is locked to a specific one.

lk-chen pushed a commit to lk-chen/vllm that referenced this pull request Apr 29, 2025
@gshtras @lk-chen
[Build][Bugfix] Restrict setuptools version to <80 (vllm-project#17320)
5d012f1 
Signed-off-by: Gregory Shtrasberg <Gregory.Shtrasberg@amd.com>
RichardoMrMu pushed a commit to RichardoMrMu/vllm that referenced this pull request May 12, 2025
@gshtras Mu Huai
[Build][Bugfix] Restrict setuptools version to <80 (vllm-project#17320)
38b7166 
Signed-off-by: Gregory Shtrasberg <Gregory.Shtrasberg@amd.com>
Signed-off-by: Mu Huai <tianbowen.tbw@antgroup.com>
zzzyq pushed a commit to zzzyq/vllm that referenced this pull request May 24, 2025
@gshtras Yuqi Zhang
[Build][Bugfix] Restrict setuptools version to <80 (vllm-project#17320)
4c724ba 
Signed-off-by: Gregory Shtrasberg <Gregory.Shtrasberg@amd.com>
Signed-off-by: Yuqi Zhang <yuqizhang@google.com>
@gshtras
gshtras deleted the setuptools_version branch November 12, 2025 21:53
@gshtras gshtras mentioned this pull request Nov 12, 2025
Merged
0826joyce pushed a commit to 0826joyce/vllm-serving-optimization that referenced this pull request May 19, 2026
@gshtras
[Build][Bugfix] Restrict setuptools version to <80 (vllm-project#17320)
fb5a1ff 
Signed-off-by: Gregory Shtrasberg <Gregory.Shtrasberg@amd.com>
philippesic pushed a commit to philippesic/vllm-semantic-cache that referenced this pull request Jul 19, 2026
@gshtras
[Build][Bugfix] Restrict setuptools version to <80 (vllm-project#17320)
0592c2b 
Signed-off-by: Gregory Shtrasberg <Gregory.Shtrasberg@amd.com>
plasticchris pushed a commit to plasticchris/vllm that referenced this pull request Jul 20, 2026
@gshtras
[Build][Bugfix] Restrict setuptools version to <80 (vllm-project#17320)
45436ba 
Signed-off-by: Gregory Shtrasberg <Gregory.Shtrasberg@amd.com>
jperezdealgaba added a commit to jperezdealgaba/vllm that referenced this pull request Sep 30, 2026
@jperezdealgaba @cursoragent
[Security] Revert setuptools bump; keep intentional upper bounds
d3b60de 
Drop the setuptools >=83 change from this PR. The <80/<81 caps remain
for ROCm editable installs and CMake build-dir reuse (see vllm-project#17320,
vllm-project#28592). Keep pyjwt >=2.14.0 and rand 0.9.3+ only.

Co-authored-by: Cursor <cursoragent@cursor.com>
Signed-off-by: Juan Pérez de Algaba <jperezde@redhat.com>
@jperezdealgaba jperezdealgaba mentioned this pull request Sep 30, 2026
Merged
2 of 5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@WoosukKwon WoosukKwon WoosukKwon approved these changes

Assignees

No one assigned

Labels

ci/build ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@gshtras @aarnphm @DarkLight1337 @WoosukKwon @vllm-bot