[Performance][gpt-oss] Revert gpt-oss max cudagraph size to 1024#28345
Merged
mgoin merged 2 commits intovllm-project:mainfrom Nov 8, 2025
Merged
[Performance][gpt-oss] Revert gpt-oss max cudagraph size to 1024#28345mgoin merged 2 commits intovllm-project:mainfrom
mgoin merged 2 commits intovllm-project:mainfrom
Conversation
Signed-off-by: Mohammad Miadh Angkad <MAngkad.BSDSBA2027@aim.edu>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request reverts the max_cudagraph_capture_size for gpt-oss from 992 back to 1024, which is a good performance improvement. The changes are correct, including the updated calculation for the number of CUDA graphs. I have one suggestion to improve code maintainability by removing an outdated FIXME comment.
Signed-off-by: Mohammad Miadh Angkad <MAngkad.BSDSBA2027@aim.edu>
mgoin
requested review from
22quinn,
LucasWilkinson,
WoosukKwon,
heheda12345 and
mgoin
github-project-automation
bot
moved this from To Triage
to Ready
in gpt-oss Issues & Enhancements
mgoin
added
performance
github-project-automation
bot
moved this from Ready
to Done
in gpt-oss Issues & Enhancements
devpatelio
pushed a commit
to SumanthRH/vllm
that referenced
this pull request
Nov 29, 2025
…m-project#28345) Signed-off-by: Mohammad Miadh Angkad <MAngkad.BSDSBA2027@aim.edu>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Now that #27840 is merged, can we also revert gpt-oss max cudagraph size to 1024? Basically reverts #25508.
cc @mgoin
Test Plan
Tested
Test Result
Works
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.