[Bugfix] Lower gpt-oss max cudagraph size to 992 to be compatible with FA3#25508
Merged
vllm-bot merged 1 commit intovllm-project:mainfrom Sep 23, 2025
Merged
Conversation
Signed-off-by: mgoin <mgoin64@gmail.com>
Contributor
There was a problem hiding this comment.
Code Review
This pull request correctly addresses a crash on Hopper GPUs for the gpt-oss model by lowering the maximum CUDA graph capture size to 992, which is the compatibility limit for FlashAttention v3. The change is well-targeted and effective. I have one suggestion to improve the code's maintainability by replacing the hardcoded value 992 with a named constant.
FeiDaLI
pushed a commit
to FeiDaLI/vllm
that referenced
this pull request
Sep 25, 2025
…h FA3 (vllm-project#25508) Signed-off-by: mgoin <mgoin64@gmail.com>
yewentao256
pushed a commit
that referenced
this pull request
Oct 3, 2025
…h FA3 (#25508) Signed-off-by: mgoin <mgoin64@gmail.com> Signed-off-by: yewentao256 <zhyanwentao@126.com>
choprahetarth
pushed a commit
to Tandemn-Labs/vllm
that referenced
this pull request
Oct 11, 2025
…h FA3 (vllm-project#25508) Signed-off-by: mgoin <mgoin64@gmail.com>
lywa1998
pushed a commit
to lywa1998/vllm
that referenced
this pull request
Oct 20, 2025
…h FA3 (vllm-project#25508) Signed-off-by: mgoin <mgoin64@gmail.com>
5 tasks
rtourgeman
pushed a commit
to rtourgeman/vllm
that referenced
this pull request
Nov 10, 2025
…h FA3 (vllm-project#25508) Signed-off-by: mgoin <mgoin64@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Due to compiling full cudagraphs by default now in #25444, gpt-oss crashes on Hopper.
Test Plan
Test Result
vllm serve openai/gpt-oss-20bcrashes on main but succeeds with this PREssential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.