[docs] Update v1 metrics design doc#27332
Merged
vllm-bot merged 7 commits intovllm-project:mainfrom Oct 22, 2025
Merged
Conversation
Signed-off-by: Simon Mo <simon.mo@hey.com> Signed-off-by: Mark McLoughlin <markmc@redhat.com>
Signed-off-by: Mark McLoughlin <markmc@redhat.com>
Signed-off-by: Mark McLoughlin <markmc@redhat.com>
Signed-off-by: Mark McLoughlin <markmc@redhat.com>
Signed-off-by: atalhens <sneh.lata@nutanix.com> Signed-off-by: Mark McLoughlin <markmc@redhat.com>
|
Documentation preview: https://vllm--27332.org.readthedocs.build/en/27332/ |
Contributor
There was a problem hiding this comment.
Code Review
This pull request provides a valuable update to the metrics design document, bringing it in line with the V1 engine's capabilities. The changes are well-executed, replacing outdated v0 information with a clear and descriptive list of V1 metrics. The restructuring of the document and the consistent use of historical terminology improve readability and context. The move to shorthand links for PRs and issues is also a nice touch for maintainability. Overall, these changes make the documentation more accurate and useful for developers and users working with vLLM's metrics.
4 tasks
Signed-off-by: Mark McLoughlin <markmc@redhat.com>
Signed-off-by: Mark McLoughlin <markmc@redhat.com>
usberkeley
pushed a commit
to usberkeley/vllm
that referenced
this pull request
Oct 23, 2025
Signed-off-by: Simon Mo <simon.mo@hey.com> Signed-off-by: Mark McLoughlin <markmc@redhat.com> Signed-off-by: atalhens <sneh.lata@nutanix.com> Co-authored-by: Simon Mo <simon.mo@hey.com> Co-authored-by: atalhens <sneh.lata@nutanix.com>
0xrushi
pushed a commit
to 0xrushi/vllm
that referenced
this pull request
Oct 26, 2025
Signed-off-by: Simon Mo <simon.mo@hey.com> Signed-off-by: Mark McLoughlin <markmc@redhat.com> Signed-off-by: atalhens <sneh.lata@nutanix.com> Co-authored-by: Simon Mo <simon.mo@hey.com> Co-authored-by: atalhens <sneh.lata@nutanix.com> Signed-off-by: 0xrushi <6279035+0xrushi@users.noreply.github.com>
0xrushi
pushed a commit
to 0xrushi/vllm
that referenced
this pull request
Oct 26, 2025
Signed-off-by: Simon Mo <simon.mo@hey.com> Signed-off-by: Mark McLoughlin <markmc@redhat.com> Signed-off-by: atalhens <sneh.lata@nutanix.com> Co-authored-by: Simon Mo <simon.mo@hey.com> Co-authored-by: atalhens <sneh.lata@nutanix.com> Signed-off-by: 0xrushi <6279035+0xrushi@users.noreply.github.com>
ilmarkov
pushed a commit
to neuralmagic/vllm
that referenced
this pull request
Nov 7, 2025
Signed-off-by: Simon Mo <simon.mo@hey.com> Signed-off-by: Mark McLoughlin <markmc@redhat.com> Signed-off-by: atalhens <sneh.lata@nutanix.com> Co-authored-by: Simon Mo <simon.mo@hey.com> Co-authored-by: atalhens <sneh.lata@nutanix.com>
rtourgeman
pushed a commit
to rtourgeman/vllm
that referenced
this pull request
Nov 10, 2025
Signed-off-by: Simon Mo <simon.mo@hey.com> Signed-off-by: Mark McLoughlin <markmc@redhat.com> Signed-off-by: atalhens <sneh.lata@nutanix.com> Co-authored-by: Simon Mo <simon.mo@hey.com> Co-authored-by: atalhens <sneh.lata@nutanix.com>
devpatelio
pushed a commit
to SumanthRH/vllm
that referenced
this pull request
Nov 29, 2025
Signed-off-by: Simon Mo <simon.mo@hey.com> Signed-off-by: Mark McLoughlin <markmc@redhat.com> Signed-off-by: atalhens <sneh.lata@nutanix.com> Co-authored-by: Simon Mo <simon.mo@hey.com> Co-authored-by: atalhens <sneh.lata@nutanix.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #27298
With this caveat:
Co-authored by @simon-mo in #26311 and @atalhens in #27301