-
-
Notifications
You must be signed in to change notification settings - Fork 11.8k
[Bugfix][P/D] Reduce num_threads used by nixl ucx backend #27196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bugfix][P/D] Reduce num_threads used by nixl ucx backend #27196
Conversation
|
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run You ask your reviewers to trigger select CI tests on top of Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add If you have any questions, please reach out to us on Slack at https://slack.vllm.ai. 🚀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request addresses a critical issue where nvshmem initialization fails due to UAR space exhaustion in RDMA environments. The fix, which reduces the number of NIXL threads for the UCX backend from 8 to 4, is well-justified and directly targets the regression. I have provided one suggestion to make this thread count configurable, which would improve flexibility for different environments while maintaining a safe default to prevent the issue from recurring.
1662707 to
71a3ec4
Compare
|
This is the failing tests: Fixed by #27195 You can rebase to pick up the fix or a committer can force merge 👍 |
This fixes an issue in RDMA environments where we ran out of UAR space while initializing nvshmem for DeepEP, when used in conjunction with P/D. Signed-off-by: David Whyte-Gray <[email protected]>
Head branch was pushed to by a user without write access
b2bf90c to
483f9ff
Compare
|
Rebased on main |
…ct#27196) Signed-off-by: David Whyte-Gray <[email protected]>
…ct#27196) Signed-off-by: David Whyte-Gray <[email protected]> Signed-off-by: sstamenk <[email protected]>
…ct#27196) Signed-off-by: David Whyte-Gray <[email protected]>
…ct#27196) Signed-off-by: David Whyte-Gray <[email protected]> Signed-off-by: Alberto Perdomo <[email protected]>
…ct#27196) Signed-off-by: David Whyte-Gray <[email protected]> Signed-off-by: 0xrushi <[email protected]>
…ct#27196) Signed-off-by: David Whyte-Gray <[email protected]> Signed-off-by: 0xrushi <[email protected]>
…ct#27196) Signed-off-by: David Whyte-Gray <[email protected]>
…ct#27196) Signed-off-by: David Whyte-Gray <[email protected]>
…ct#27196) Signed-off-by: David Whyte-Gray <[email protected]>
…ct#27196) Signed-off-by: David Whyte-Gray <[email protected]>
This PR adds the ability to configure the number of UCX threads used for the NIXL backend agents.
Example usage:
--kv-transfer-config '{"kv_connector": "NixlConnector", "kv_role": "kv_both", "kv_connector_extra_config": {"num_threads": 2}}'Purpose
This PR fixes an issue with WideEP in RDMA environments where we ran out of UAR space while initializing nvshmem for multi-node DeepEP, when used in conjunction with P/D.
This issue would result in logs like
This issue is not seen prior to 8ce5d31 where num_threads=8 was introduced. Some investigation with bpftrace revealed that in vLLM versions since this change, there are more UAR allocations by NIXL (from ~550 to ~1640), which explains the resource shortage later on in the start-up process when nvshmem is being bootstrapped.
Test Plan
Tested
VLLM_ALL2ALL_BACKEND=deepep_low_latencywith this change on a 3x8xH100 node environment on IBM Cloud.Test Result
The above error is resolved and the model (Qwen-235B-A22B) loaded successfully.
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.