[Bugfix] Fix qwen3-omni audio truncation issue#26815
Merged
DarkLight1337 merged 4 commits intovllm-project:mainfrom Oct 15, 2025
Merged
[Bugfix] Fix qwen3-omni audio truncation issue#26815DarkLight1337 merged 4 commits intovllm-project:mainfrom
DarkLight1337 merged 4 commits intovllm-project:mainfrom
Conversation
Signed-off-by: Isotr0py <mozf@mail2.sysu.edu.cn>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request addresses an audio truncation issue in the Qwen3-Omni model where inputs were always limited to 30 seconds. The changes introduce a conditional truncation mechanism based on the truncation argument in mm_kwargs, which correctly allows for processing longer audio clips. The associated refactoring, which includes hoisting the feature_extractor and hop_length initializations and removing redundant code, is clean and necessary for the fix. The implementation is sound and effectively resolves the reported bug.
Member
Author
|
After second thought, I think we can still add some patch here so that user doesn't need to wait Transformers patch release. |
Signed-off-by: Isotr0py <mozf@mail2.sysu.edu.cn>
| return x | ||
|
|
||
| # NOTE: WhisperFeatureExtractor cannot handle empty list of audios | ||
| feature_extractor = self.info.get_feature_extractor() |
Member
There was a problem hiding this comment.
Can you add a comment so we can revert once it's fixed on transformers side?
Signed-off-by: Isotr0py <mozf@mail2.sysu.edu.cn>
DarkLight1337
approved these changes
Oct 15, 2025
github-actions
bot
added
the
ready
bbartels
pushed a commit
to bbartels/vllm
that referenced
this pull request
Oct 16, 2025
Signed-off-by: Isotr0py <mozf@mail2.sysu.edu.cn> Signed-off-by: bbartels <benjamin@bartels.dev>
lywa1998
pushed a commit
to lywa1998/vllm
that referenced
this pull request
Oct 20, 2025
Signed-off-by: Isotr0py <mozf@mail2.sysu.edu.cn>
alhridoy
pushed a commit
to alhridoy/vllm
that referenced
this pull request
Oct 24, 2025
Signed-off-by: Isotr0py <mozf@mail2.sysu.edu.cn>
0xrushi
pushed a commit
to 0xrushi/vllm
that referenced
this pull request
Oct 26, 2025
Signed-off-by: Isotr0py <mozf@mail2.sysu.edu.cn> Signed-off-by: 0xrushi <6279035+0xrushi@users.noreply.github.com>
0xrushi
pushed a commit
to 0xrushi/vllm
that referenced
this pull request
Oct 26, 2025
Signed-off-by: Isotr0py <mozf@mail2.sysu.edu.cn> Signed-off-by: 0xrushi <6279035+0xrushi@users.noreply.github.com>
wenbinc-Bin
pushed a commit
to wenbinc-Bin/vllm-fork
that referenced
this pull request
Nov 7, 2025
Signed-off-by: Isotr0py <mozf@mail2.sysu.edu.cn>
rtourgeman
pushed a commit
to rtourgeman/vllm
that referenced
this pull request
Nov 10, 2025
Signed-off-by: Isotr0py <mozf@mail2.sysu.edu.cn>
devpatelio
pushed a commit
to SumanthRH/vllm
that referenced
this pull request
Nov 29, 2025
Signed-off-by: Isotr0py <mozf@mail2.sysu.edu.cn>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
truncationtoFalsein Qwen3Omni to avoid default truncation huggingface/transformers#41473, Qwen3-omni will still truncate audio to 30s.Test Plan
Test Result
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.