Set truncation to False in Qwen3Omni to avoid default truncation#41473
Merged
zucchini-nlp merged 2 commits intohuggingface:mainfrom Oct 10, 2025
Merged
Set truncation to False in Qwen3Omni to avoid default truncation#41473zucchini-nlp merged 2 commits intohuggingface:mainfrom
truncation to False in Qwen3Omni to avoid default truncation#41473zucchini-nlp merged 2 commits intohuggingface:mainfrom
Conversation
Member
|
cc @zucchini-nlp maybe? |
zucchini-nlp
approved these changes
Oct 10, 2025
Member
There was a problem hiding this comment.
LGTM, why don't we add it in 'defaults' though in the processor's typed dict? That should work for all cases unless user specifically sets it to False
That way we don't hardcode and the params are still configurable, for whatever reason users might want to
Contributor
Author
|
@zucchini-nlp fixed |
Contributor
|
[For maintainers] Suggested jobs to run (before merge) run-slow: qwen3_omni_moe |
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
AhnJoonSung
pushed a commit
to AhnJoonSung/transformers
that referenced
this pull request
Oct 12, 2025
…uggingface#41473) * Set `truncation` to `False` in Qwen3Omni to avoid default truncation * move `padding` and `truncation` to audio default args --------- Co-authored-by: lvyuanjun.lyj <lvyuanjun.lyj@alibaba-inc.com>
This was referenced Oct 14, 2025
ngazagna-qc
pushed a commit
to ngazagna-qc/transformers
that referenced
this pull request
Oct 23, 2025
…uggingface#41473) * Set `truncation` to `False` in Qwen3Omni to avoid default truncation * move `padding` and `truncation` to audio default args --------- Co-authored-by: lvyuanjun.lyj <lvyuanjun.lyj@alibaba-inc.com>
sarapapi
pushed a commit
to hlt-mt/mcif
that referenced
this pull request
Mar 24, 2026
WhisperFeatureExtractor defaults to truncation=True, silently cutting audio longer than 30s. Qwen3OmniMoeProcessor (tested at [v4.57.6](https://github.com/huggingface/transformers/releases/tag/v4.57.6)) does not overrides this. Explicitly passing `truncation=False` makes sure full audio is processed, matching the fix in huggingface/transformers#41473.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes QwenLM/Qwen3-Omni#40
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.