[CI/Build][Bugfix] fix qutlass cmake error when set QUTLASS_SRC_DIR#26773
Merged
mgoin merged 3 commits intovllm-project:mainfrom Oct 15, 2025
Merged
[CI/Build][Bugfix] fix qutlass cmake error when set QUTLASS_SRC_DIR#26773mgoin merged 3 commits intovllm-project:mainfrom
mgoin merged 3 commits intovllm-project:mainfrom
Conversation
Signed-off-by: izhuhaoran <izhuhaoran@qq.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request correctly fixes a CMake build error for the qutlass external project that occurs when QUTLASS_SRC_DIR is specified. The change to use FetchContent_MakeAvailable is the proper, idiomatic solution, making the build script more robust. The fix is sound. I have one suggestion to improve logging consistency for better maintainability.
| endif() | ||
| message(STATUS "[QUTLASS] QuTLASS is available at ${qutlass_SOURCE_DIR}") | ||
| FetchContent_MakeAvailable(qutlass) | ||
| message(STATUS "QuTLASS is available at ${qutlass_SOURCE_DIR}") |
Contributor
There was a problem hiding this comment.
For consistency with other log messages in this file, it is recommended to retain the [QUTLASS] prefix. This helps in quickly identifying the origin of build messages, which is valuable for debugging build issues.
message(STATUS "[QUTLASS] QuTLASS is available at ${qutlass_SOURCE_DIR}")
…avoid custlass already exists error Signed-off-by: izhuhaoran <izhuhaoran@qq.com>
Member
|
cc @mgoin |
mgoin
approved these changes
Oct 14, 2025
Member
mgoin
left a comment
mgoin
left a comment
There was a problem hiding this comment.
LGTM although I'm not sure why FetchContent_Populate is needed if flashmla doesn't need it
mgoin
added
bug
Contributor
Author
flashmla.cmake use FetchContent_MakeAvailable, which contains FetchContent_Populate. |
Closed
5 tasks
bbartels
pushed a commit
to bbartels/vllm
that referenced
this pull request
Oct 16, 2025
…llm-project#26773) Signed-off-by: izhuhaoran <izhuhaoran@qq.com> Co-authored-by: Michael Goin <mgoin64@gmail.com> Signed-off-by: bbartels <benjamin@bartels.dev>
lywa1998
pushed a commit
to lywa1998/vllm
that referenced
this pull request
Oct 20, 2025
…llm-project#26773) Signed-off-by: izhuhaoran <izhuhaoran@qq.com> Co-authored-by: Michael Goin <mgoin64@gmail.com>
13 tasks
alhridoy
pushed a commit
to alhridoy/vllm
that referenced
this pull request
Oct 24, 2025
…llm-project#26773) Signed-off-by: izhuhaoran <izhuhaoran@qq.com> Co-authored-by: Michael Goin <mgoin64@gmail.com>
0xrushi
pushed a commit
to 0xrushi/vllm
that referenced
this pull request
Oct 26, 2025
…llm-project#26773) Signed-off-by: izhuhaoran <izhuhaoran@qq.com> Co-authored-by: Michael Goin <mgoin64@gmail.com> Signed-off-by: 0xrushi <6279035+0xrushi@users.noreply.github.com>
0xrushi
pushed a commit
to 0xrushi/vllm
that referenced
this pull request
Oct 26, 2025
…llm-project#26773) Signed-off-by: izhuhaoran <izhuhaoran@qq.com> Co-authored-by: Michael Goin <mgoin64@gmail.com> Signed-off-by: 0xrushi <6279035+0xrushi@users.noreply.github.com>
rtourgeman
pushed a commit
to rtourgeman/vllm
that referenced
this pull request
Nov 10, 2025
…llm-project#26773) Signed-off-by: izhuhaoran <izhuhaoran@qq.com> Co-authored-by: Michael Goin <mgoin64@gmail.com>
devpatelio
pushed a commit
to SumanthRH/vllm
that referenced
this pull request
Nov 29, 2025
…llm-project#26773) Signed-off-by: izhuhaoran <izhuhaoran@qq.com> Co-authored-by: Michael Goin <mgoin64@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
When building from source with QUTLASS_SRC_DIR specified, the current code encounters the following error:
The cause is that when specifying QUTLASS_SRC_DIR, only FetchContent_Declare is executed, but FetchContent_Populate is omitted. This results in qutlass_SOURCE_DIR remaining undefined.
This PR fixes the error the same way as in
cmake/external_projects/flashmla.cmakeEssential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.