[Bugfix][CI/Build] Fix build error when using QUTLASS_SRC_DIR to build vllm from source.#26688
Closed
FENP wants to merge 2 commits intovllm-project:mainfrom
Closed
[Bugfix][CI/Build] Fix build error when using QUTLASS_SRC_DIR to build vllm from source.#26688FENP wants to merge 2 commits intovllm-project:mainfrom
FENP wants to merge 2 commits intovllm-project:mainfrom
Conversation
Signed-off-by: FENP <32334296+FENP@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Code Review
This pull request correctly identifies and fixes a build error that occurs when building with a local QUTLASS_SRC_DIR. The issue is that qutlass_SOURCE_DIR was not being set in this scenario, leading to a fatal error. Your change directly addresses this by setting the variable. I've provided one suggestion to use a more idiomatic FetchContent command, which also solves the issue while improving consistency within the script.
Signed-off-by: FENP <32334296+FENP@users.noreply.github.com>
Contributor
|
LGTM! Thanks for the fix. |
Contributor
Author
|
#26773 was merged to fix the error. Close |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
#24440 brings in the QuTLASS library, and I found a small build issue here.
A FATAL_ERROR will be triggered when using QUTLASS_SRC_DIR to build vllm from source.
vllm/cmake/external_projects/qutlass.cmake
Lines 29 to 31 in 98f30b8
This pull request fixes build error when use local qutlass source directory via environment variable.
Test Plan
QUTLASS_SRC_DIR=/path/to/qutlass uv pip install -e .Test Result
Build on SM90 and everything is ok (qutlass build is skipped).
cc @LopezCastroRoberto @mgoin
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.