Skip to content

[CI Perf]Prune Tests in kernel/mamba #26538

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 13, 2025
Merged

[CI Perf]Prune Tests in kernel/mamba #26538

merged 4 commits into from
Oct 13, 2025

Conversation

@kfhfar
Copy link
Contributor

@kfhfar kfhfar commented Oct 9, 2025 •
edited by github-actions bot
Loading

Purpose

This is part of #22041 and CI sprint. This is for pruning the Kernel mamba tests. Used #22936, #22939 for reference.

Test Plan

pytest tests/kernels/mamba

Test Result

Still to complete

Essential Elements of an Effective PR Description Checklist
  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.
  • (Optional) Release notes update. If your change is user facing, please update the release notes draft in the Google Doc.

yewentao256
yewentao256 reviewed Oct 9, 2025
View reviewed changes
Copy link
Member

@yewentao256 yewentao256 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the work!
Generally, please do not affect the functionality like removing test dtype.
Some redundant test could be removed like [128, 256, 512, 1024, 2048, 4096]) to [128, 1024, 4096]) is good.

tests/kernels/mamba/test_causal_conv1d.py
return (out if activation is None else F.silu(out)).to(dtype=dtype_in)


@pytest.mark.parametrize("itype", [torch.bfloat16, torch.float])
Copy link
Member

@yewentao256 yewentao256 Oct 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test for float is needed

Copy link
Contributor Author

@kfhfar kfhfar Oct 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack.

tests/kernels/mamba/test_causal_conv1d.py
@pytest.mark.parametrize("has_bias", [False, True])
@pytest.mark.parametrize("seqlen", [1])
@pytest.mark.parametrize("width", [4])
@pytest.mark.parametrize("dim", [2048, 2048 + 16, 4096])
Copy link
Member

@yewentao256 yewentao256 Oct 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test for arbitrary shape is needed

Copy link
Contributor Author

@kfhfar kfhfar Oct 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack

@kfhfar
Testing with update kernel-mamba running configs
288ea5a 
Signed-off-by: kfhfar <[email protected]>
Signed-off-by: Fardin Hoque <[email protected]>

Removing bfloat16 as added accidentally

Signed-off-by: Fardin Hoque <[email protected]>
yewentao256
yewentao256 reviewed Oct 11, 2025
View reviewed changes
Copy link
Member

@yewentao256 yewentao256 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the work! Just a few thoughts

@kfhfar kfhfar marked this pull request as ready for review October 13, 2025 00:08
yewentao256
yewentao256 approved these changes Oct 13, 2025
View reviewed changes
Copy link
Member

@yewentao256 yewentao256 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the work!

@yewentao256 yewentao256 added the ready ONLY add when PR is ready to merge/full CI is needed label Oct 13, 2025
@yewentao256 yewentao256 merged commit 577c72a into vllm-project:main Oct 13, 2025
18 checks passed
@kfhfar kfhfar mentioned this pull request Oct 13, 2025
Closed
1 task
1994 pushed a commit to 1994/vllm that referenced this pull request Oct 14, 2025
@kfhfar @yewentao256 @1994
[CI Perf]Prune Tests in kernel/mamba (vllm-project#26538)
73d8952 
Signed-off-by: Fardin Hoque <[email protected]>
Signed-off-by: Wentao Ye <[email protected]>
Co-authored-by: Wentao Ye <[email protected]>
Signed-off-by: 1994 <[email protected]>
Dhruvilbhatt pushed a commit to Dhruvilbhatt/vllm that referenced this pull request Oct 14, 2025
@kfhfar @yewentao256 @Dhruvilbhatt
[CI Perf]Prune Tests in kernel/mamba (vllm-project#26538)
b80c346 
Signed-off-by: Fardin Hoque <[email protected]>
Signed-off-by: Wentao Ye <[email protected]>
Co-authored-by: Wentao Ye <[email protected]>
Signed-off-by: Dhruvil Bhatt <[email protected]>
bbartels pushed a commit to bbartels/vllm that referenced this pull request Oct 16, 2025
@kfhfar @yewentao256 @bbartels
[CI Perf]Prune Tests in kernel/mamba (vllm-project#26538)
8d9341e 
Signed-off-by: Fardin Hoque <[email protected]>
Signed-off-by: Wentao Ye <[email protected]>
Co-authored-by: Wentao Ye <[email protected]>
Signed-off-by: bbartels <[email protected]>
lywa1998 pushed a commit to lywa1998/vllm that referenced this pull request Oct 20, 2025
@kfhfar @yewentao256 @lywa1998
[CI Perf]Prune Tests in kernel/mamba (vllm-project#26538)
855537e 
Signed-off-by: Fardin Hoque <[email protected]>
Signed-off-by: Wentao Ye <[email protected]>
Co-authored-by: Wentao Ye <[email protected]>
@RishiAstra RishiAstra mentioned this pull request Oct 21, 2025
Open
5 tasks
alhridoy pushed a commit to alhridoy/vllm that referenced this pull request Oct 24, 2025
@kfhfar @yewentao256 @alhridoy
[CI Perf]Prune Tests in kernel/mamba (vllm-project#26538)
7a7b790 
Signed-off-by: Fardin Hoque <[email protected]>
Signed-off-by: Wentao Ye <[email protected]>
Co-authored-by: Wentao Ye <[email protected]>
xuebwang-amd pushed a commit to xuebwang-amd/vllm that referenced this pull request Oct 24, 2025
@kfhfar @yewentao256 @xuebwang-amd
[CI Perf]Prune Tests in kernel/mamba (vllm-project#26538)
f6f36d6 
Signed-off-by: Fardin Hoque <[email protected]>
Signed-off-by: Wentao Ye <[email protected]>
Co-authored-by: Wentao Ye <[email protected]>
Signed-off-by: xuebwang-amd <[email protected]>
xuebwang-amd pushed a commit to xuebwang-amd/vllm that referenced this pull request Oct 24, 2025
@kfhfar @yewentao256 @xuebwang-amd
[CI Perf]Prune Tests in kernel/mamba (vllm-project#26538)
22a9263 
Signed-off-by: Fardin Hoque <[email protected]>
Signed-off-by: Wentao Ye <[email protected]>
Co-authored-by: Wentao Ye <[email protected]>
Signed-off-by: xuebwang-amd <[email protected]>
0xrushi pushed a commit to 0xrushi/vllm that referenced this pull request Oct 26, 2025
@kfhfar @yewentao256 @0xrushi
[CI Perf]Prune Tests in kernel/mamba (vllm-project#26538)
942f2d1 
Signed-off-by: Fardin Hoque <[email protected]>
Signed-off-by: Wentao Ye <[email protected]>
Co-authored-by: Wentao Ye <[email protected]>
Signed-off-by: 0xrushi <[email protected]>
0xrushi pushed a commit to 0xrushi/vllm that referenced this pull request Oct 26, 2025
@kfhfar @yewentao256 @0xrushi
[CI Perf]Prune Tests in kernel/mamba (vllm-project#26538)
7e0a22d 
Signed-off-by: Fardin Hoque <[email protected]>
Signed-off-by: Wentao Ye <[email protected]>
Co-authored-by: Wentao Ye <[email protected]>
Signed-off-by: 0xrushi <[email protected]>
rtourgeman pushed a commit to rtourgeman/vllm that referenced this pull request Nov 10, 2025
@kfhfar @yewentao256 @rtourgeman
[CI Perf]Prune Tests in kernel/mamba (vllm-project#26538)
128ed60 
Signed-off-by: Fardin Hoque <[email protected]>
Signed-off-by: Wentao Ye <[email protected]>
Co-authored-by: Wentao Ye <[email protected]>
Zhathw pushed a commit to Zhathw/vllm that referenced this pull request Nov 12, 2025
@kfhfar @yewentao256 @Zhathw
[CI Perf]Prune Tests in kernel/mamba (vllm-project#26538)
30475e8 
Signed-off-by: Fardin Hoque <[email protected]>
Signed-off-by: Wentao Ye <[email protected]>
Co-authored-by: Wentao Ye <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yewentao256 yewentao256 yewentao256 approved these changes

@mgoin mgoin Awaiting requested review from mgoin mgoin is a code owner

@tlrmchlsmth tlrmchlsmth Awaiting requested review from tlrmchlsmth tlrmchlsmth is a code owner

@WoosukKwon WoosukKwon Awaiting requested review from WoosukKwon WoosukKwon is a code owner

Assignees

No one assigned

Labels

ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kfhfar @yewentao256