-
-
Notifications
You must be signed in to change notification settings - Fork 11.3k
[CI Perf] Prune tests in tests/kernels/attention/
#22936
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI Perf] Prune tests in tests/kernels/attention/
#22936
Conversation
Signed-off-by: mgoin <[email protected]>
|
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request aims to optimize CI by pruning the test matrix in various attention kernel tests. The changes primarily involve reducing the number of parameterized values for tests, such as number of heads, head sizes, block sizes, and data types.
While most of the pruning seems reasonable for CI optimization, I've identified a recurring high-risk change across multiple test files: the removal of torch.float16 from the tested data types. Given that float16 is a very common data type in production, removing it from the test suite could lead to undetected regressions. I have added comments to suggest re-introducing torch.float16 to the test matrix in the affected files to maintain test coverage for this critical data type.
tests/kernels/attention/tests/kernels/attention/
yewentao256
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for the work!
Signed-off-by: mgoin <[email protected]>
Signed-off-by: mgoin <[email protected]>
Signed-off-by: mgoin <[email protected]> Signed-off-by: Duncan Moss <[email protected]>
Signed-off-by: mgoin <[email protected]>
Signed-off-by: mgoin <[email protected]> Signed-off-by: Xiao Yu <[email protected]>
Signed-off-by: mgoin <[email protected]>
Purpose
Greatly reduce the number of test cases generated by:
This is still not aggressive enough IMO because we are still testing all permutations. Best practice would be to just come up with fixed test points and applying those directly, rather than permutations.
Counts for each test:
Test Plan
Test Result
(Optional) Documentation Update
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.