-
-
Notifications
You must be signed in to change notification settings - Fork 11.5k
[Build/CI] Revert back to Ubuntu 20.04, install python 3.12 with uv #26103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Tyler Michael Smith <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request aims to revert the build image to Ubuntu 20.04 for better glibc compatibility and to switch to uv for Python installation. The changes in the base stage of the Dockerfile correctly implement this, simplifying the Python setup.
However, there is a critical omission: the vllm-base stage (starting at line 271) has not been updated. It still uses the old deadsnakes PPA method for installing Python, which is inconsistent with the changes made in the base stage and the stated goal of the PR. To fully adopt uv for Python management and ensure consistency across the Docker build, the vllm-base stage must be refactored to use the same uv-based Python installation method.
Additionally, I've left one comment regarding an improvement for build script robustness.
Signed-off-by: Tyler Michael Smith <[email protected]>
ProExpertProg
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for doing this!
|
UV not happy |
75cbb15 to
159b581
Compare
|
@codex review |
|
Codex Review: Didn't find any major issues. Another round soon, please! ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting |
|
I'll just merge this in given pip install is working |
…26103) Signed-off-by: Tyler Michael Smith <[email protected]> Co-authored-by: Simon Mo <[email protected]> Signed-off-by: simon-mo <[email protected]>
…26103) Signed-off-by: Tyler Michael Smith <[email protected]> Co-authored-by: Simon Mo <[email protected]> Signed-off-by: yewentao256 <[email protected]>
…llm-project#26103) Signed-off-by: Tyler Michael Smith <[email protected]> Co-authored-by: Simon Mo <[email protected]> Signed-off-by: Tomer Asida <[email protected]>
…llm-project#26103) Signed-off-by: Tyler Michael Smith <[email protected]> Co-authored-by: Simon Mo <[email protected]> Signed-off-by: Karan Goel <[email protected]>
…llm-project#26103) Signed-off-by: Tyler Michael Smith <[email protected]> Co-authored-by: Simon Mo <[email protected]>
…llm-project#26103) Signed-off-by: Tyler Michael Smith <[email protected]> Co-authored-by: Simon Mo <[email protected]> Signed-off-by: xuebwang-amd <[email protected]>
…llm-project#26103) Signed-off-by: Tyler Michael Smith <[email protected]> Co-authored-by: Simon Mo <[email protected]> Signed-off-by: simon-mo <[email protected]>
…t#26103) Signed-off-by: Tyler Michael Smith <[email protected]> Co-authored-by: Simon Mo <[email protected]> Signed-off-by: simon-mo <[email protected]>
…llm-project#26103) Signed-off-by: Tyler Michael Smith <[email protected]> Co-authored-by: Simon Mo <[email protected]>
…llm-project#26103) Signed-off-by: Tyler Michael Smith <[email protected]> Co-authored-by: Simon Mo <[email protected]>
…llm-project#26103) Signed-off-by: Tyler Michael Smith <[email protected]> Co-authored-by: Simon Mo <[email protected]> Signed-off-by: xuebwang-amd <[email protected]>
…llm-project#26103) Signed-off-by: Tyler Michael Smith <[email protected]> Co-authored-by: Simon Mo <[email protected]>
Revert back to 20.04 to avoid breaking the wheel for users on OSes such as UBI 9 that have an earlier glibc version than 20.04.
Also use uv to install python 3.12 instead of deadsnakes.